Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v0.55] manifests,push: add support for AddCompression #1594

Closed
wants to merge 3 commits into from
Closed

[release-v0.55] manifests,push: add support for AddCompression #1594

wants to merge 3 commits into from

Conversation

flouthoc
Copy link
Collaborator

@flouthoc flouthoc commented Aug 4, 2023

flouthoc added 2 commits August 4, 2023 16:44
@flouthoc
manifests,push: add support for AddCompression
b178ac8 
`c/image` recently added support for EnsureCompressionVariantsExist,
following PR exposes the feature to `c/common` manifests so actual users
can use it.

Signed-off-by: Aditya R <[email protected]>
@flouthoc
libimage/ManifestPushOptions: add AddCompression from containers#1585
68a62fd 
Podman uses different API for pushing manifest list,
add `AddCompression` to ManifestPushOptions, which is implemented
here: containers#1585

[NO NEW TESTS NEEDED]
Tests are added here: containers#1585

Signed-off-by: Aditya R <[email protected]>
@flouthoc
Copy link
Collaborator Author

flouthoc commented Aug 4, 2023

@mtrmac @TomSweeneyRedHat PTAL

@flouthoc
Copy link
Collaborator Author

flouthoc commented Aug 4, 2023

Needs: containers/image#2071

@TomSweeneyRedHat
Copy link
Member

LGTM, once the image pr is merged
/hold

@TomSweeneyRedHat
Copy link
Member

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, TomSweeneyRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 4, 2023
@TomSweeneyRedHat
Copy link
Member

/approved

mtrmac
mtrmac reviewed Aug 7, 2023
View reviewed changes
Copy link
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct from a 5-second skim; I didn’t look into whether this is the right branch.

@vrothberg
Copy link
Member

Why are we backporting features? We passed the deadline by a large margin.

@flouthoc
Copy link
Collaborator Author

flouthoc commented Aug 7, 2023

@vrothberg As @TomSweeneyRedHat suggested that v4.6.1 branch will be created for RHEL from v4.6 and we have to backport the feature there. cc @TomSweeneyRedHat could you correct if i got something wrong.

@TomSweeneyRedHat
Copy link
Member

Sorry for the run around @flouthoc on this one. After our talk during today's meeting, this should not be added to Podman v4.6.1 or the Podman v4.6 Branch. We'll aim this fix at Podman v4.7. @flouthoc, there are no dependencies on this in the v4.6 Podman branch at the moment, correct? I will close this for now, and we can reopen later if I'm mistaken.

@flouthoc
Copy link
Collaborator Author

flouthoc commented Aug 8, 2023

@flouthoc, there are no dependencies on this in the v4.6 Podman branch at the moment, correct?

Nope, everything is only present in upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrmac mtrmac mtrmac left review comments

Assignees
No one assigned
Labels
approved do-not-merge/hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flouthoc @TomSweeneyRedHat @vrothberg @mtrmac