ostree-ext: Serialize xattrs into tar stream as well #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prep for next patch. Signed-off-by: Colin Walters <[email protected]>
cgwalters
force-pushed
the
export-xattrs
branch
from
c0df7af to
f21f6d8
Compare
|
Interesting. The unit tests passed in GHA, but failed in copr. Need to dig into that... |
cgwalters
force-pushed
the
export-xattrs
branch
2 times, most recently
from
4cb29b5 to
f61c38d
Compare
|
No idea what's up with the unit tests in COPR but I added some code to dump the filesystem tree if the checksum doesn't match |
|
Ah hah! It's just c{9,10}s failing because those have ostree-2024.10 which has ostreedev/ostree#3346 which sorts xattrs. I need to fix our test suite to do that too. Edit: Done ✔️ |
We really want this for coreos/rpm-ostree#5222 to be able to rebuild images from their container-synthesized rootfs. Really, the only xattr we don't want to emit in to the tar stream is security.selinux for now. Eventually we should try to switch to putting that into the tar stream too, but it needs more validation. Signed-off-by: Colin Walters <[email protected]>
cgwalters
force-pushed
the
export-xattrs
branch
from
f61c38d to
a192370
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We really want this for coreos/rpm-ostree#5222
to be able to rebuild images from their container-synthesized rootfs.
Really, the only xattr we don't want to emit in to the tar stream
is security.selinux for now.
Eventually we should try to switch to putting that into the tar
stream too, but it needs more validation.
Signed-off-by: Colin Walters [email protected]