Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Handle not having skopeo present #1003

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

cgwalters
Copy link
Collaborator

@cgwalters cgwalters commented Jan 3, 2025

Fallout from the ostree-ext merge. We were missing a BuildRequires
in the spec, which caused our unit tests to fail in Fedora.
I since added that BuildRequires, but let's change our tests
to skip if it's not present.

Signed-off-by: Colin Walters [email protected]

This would be a nice thing to try to standardize, but let's just
keep track of this and use it in our CI install flow too. This
helps us be cross distribution a bit more.

Signed-off-by: Colin Walters <[email protected]>
Fallout from the ostree-ext merge. We were missing a `BuildRequires`
in the spec, which caused our unit tests to fail in Fedora.
I since added that BuildRequires, but let's change our tests
to skip if it's not present.

Signed-off-by: Colin Walters <[email protected]>
@cgwalters cgwalters enabled auto-merge January 3, 2025 20:07
@cgwalters
Copy link
Collaborator Author

Also tangential but rpm-software-management/rpm#3504

Copy link
Member

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cgwalters cgwalters disabled auto-merge January 6, 2025 19:34
@cgwalters cgwalters merged commit 86a06ec into containers:main Jan 6, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants