Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install: Never traverse mount points with --wipe #1001

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

cgwalters
Copy link
Collaborator

@cgwalters cgwalters commented Jan 2, 2025

utils: Move open_dir_noxdev here

Prep for using it elsewhere.

Signed-off-by: Colin Walters [email protected]


install: Never traverse mount points with --wipe

If we encounter a mount point when attempting to
wipe a filesystem, then something has definitely gone
wrong. At the install phase we should only be operating
on a single physical filesystem.

Motivated by #997

Signed-off-by: Colin Walters [email protected]


Prep for using it elsewhere.

Signed-off-by: Colin Walters <[email protected]>
@cgwalters

This comment was marked as outdated.

@cgwalters cgwalters marked this pull request as draft January 2, 2025 18:40
If we encounter a mount point when attempting to
wipe a filesystem, then something has definitely gone
wrong. At the install phase we should only be operating
on a single physical filesystem.

Signed-off-by: Colin Walters <[email protected]>
@cgwalters cgwalters marked this pull request as ready for review January 2, 2025 21:44
@cgwalters cgwalters enabled auto-merge January 3, 2025 01:53
Copy link
Member

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cgwalters cgwalters merged commit 38e6528 into containers:main Jan 6, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/install Issues related to `bootc install`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants