feat(utils): implement symlink sandbox for cachi2 #2139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What/why: implement detection/removal of unsafe symlinks in repos, specifically
covering cachi2 use case: Cachito already does this
How:
- copypasta `_enforce_sandbox()` and related unit tests from Cachito
("cachito/cachito/workers/tasks/general.py" and
"cachito/tests/test_workers/test_tasks/test_general.py", respectively)
- add call to `_enforce_sandbox()`
- add CLI boolean arg `remove-unsafe-symlinks`, which toggles removing all
symlinks which point to location(s) outside of any cloned repository
Signed-off-by: Ben Alkov <[email protected]>
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
|
LGTM, just tests are failing for some reason |
why is this in commit message? |
MartinBasti
reviewed
Dec 18, 2024
| @@ -135,6 +135,7 @@ def process_remote_sources(self) -> List[Dict[str, Any]]: | |||
| remote_source_data["ref"] | |||
| ) | |||
|
|
|||
| enforce_sandbox(source_path_app, remove_unsafe_symlinks=False) | |||
There was a problem hiding this comment.
will be removal of unsafe symlinks implemented in followup PR?
There was a problem hiding this comment.
I had intended it for this PR, but it can be in a followup if you want to get this merged sooner.
It's a pre-commit hook to check for secrets. |
ben-alkov
merged commit f7064c7
into
containerbuildsystem:feature_cachi2
9 of 12 checks passed
But why should a random local RH specific pre-commit be recorded in commits upstream? |
Noted. Commit message disabled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/why: implement detection/removal of unsafe symlinks in repos, specifically
covering cachi2 use case: Cachito already does this
How:
_enforce_sandbox()and related unit tests from Cachito ("cachito/cachito/workers/tasks/general.py" and "cachito/tests/test_workers/test_tasks/test_general.py", respectively)_enforce_sandbox()remove-unsafe-symlinks, which toggles removing all symlinks which point to location(s) outside of any cloned repositorySigned-off-by: Ben Alkov [email protected]
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
Maintainers will complete the following section