cachi2: allow only relative paths #2137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chmeliik
reviewed
Dec 6, 2024
atomic_reactor/utils/cachi2.py
Outdated
| return False | ||
|
|
||
| fake_root = Path("/fake_root") | ||
| full_path = (fake_root/path).resolve() |
There was a problem hiding this comment.
A path may be OK within a fake root but not within a real root (if it's a symlink in the real root)
There was a problem hiding this comment.
@ben-alkov is working on symlink check, no symlinks out of cloned repo allowed.
There was a problem hiding this comment.
but I can rework it to use real cloned data, not a big issue to be sure that validation is complete
There was a problem hiding this comment.
is working on symlink check, no symlinks out of cloned repo allowed.
Hmm, ok
There was a problem hiding this comment.
But yeah, if it's not a big change to run on the real repo, that would be nicer
chmeliik
approved these changes
Dec 6, 2024
For security reasons, only relative paths within cloned remote source can be specified by users Don't allow to point to symlink pointing out of cloned remote source Signed-off-by: Martin Basti <[email protected]>
MartinBasti
force-pushed
the
cachi2_relative_paths_only
branch
from
2198483 to
9bd3a64
Compare
|
Updated to check symlinks, PTAL |
mkosiarc
approved these changes
Dec 9, 2024
MartinBasti
merged commit 4246270
into
containerbuildsystem:feature_cachi2
14 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For security reasons, only relative paths within cloned remote source can be specified by users
Maintainers will complete the following section