Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cachi2 empty pkg managers #2132

Conversation

MartinBasti
Copy link
Contributor

@MartinBasti MartinBasti commented Nov 25, 2024

When users specify empty list as pkg_managers, only cloning should be
done. In this case usage of cachi2 must be skipped and required files
like env.json and bom.json must be created by OSBS.

Maintainers will complete the following section

  • Commit messages are descriptive enough
  • Code coverage from testing does not decrease and new code is covered
  • Python type annotations added to new code
  • JSON/YAML configuration changes are updated in the relevant schema
  • Changes to metadata also update the documentation for the metadata
  • Pull request has a link to an osbs-docs PR for user documentation updates
  • New feature can be disabled from a configuration file

@MartinBasti MartinBasti changed the base branch from master to feature_cachi2 November 25, 2024 19:11
@MartinBasti MartinBasti force-pushed the cachi2-empty-pkg-managers branch from 4888bab to bae8002 Compare November 26, 2024 18:37
@MartinBasti MartinBasti marked this pull request as ready for review November 26, 2024 19:17
tekton/tasks/binary-container-cachi2.yaml Outdated Show resolved Hide resolved
tekton/tasks/binary-container-cachi2.yaml Show resolved Hide resolved
atomic_reactor/utils/cachi2.py Outdated Show resolved Hide resolved
atomic_reactor/plugins/cachi2_init.py Outdated Show resolved Hide resolved
@MartinBasti MartinBasti force-pushed the cachi2-empty-pkg-managers branch from bae8002 to 7a39f52 Compare November 27, 2024 13:54
@MartinBasti
Copy link
Contributor Author

updated, reworded

When users specify empty list as pkg_managers, only cloning should be
done. In this case usage of cachi2 must be skipped and required files
like env.json and bom.json must be created by OSBS.

Signed-off-by: Martin Basti <[email protected]>
@MartinBasti MartinBasti force-pushed the cachi2-empty-pkg-managers branch from 7a39f52 to 26578c0 Compare November 28, 2024 13:21
@MartinBasti
Copy link
Contributor Author

Rebased and removed DO NOT MERGE commit

@MartinBasti MartinBasti merged commit 7055df8 into containerbuildsystem:feature_cachi2 Nov 28, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants