feat(remote_source): upload all metadata #2106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinBasti
force-pushed
the
upload-all-cachito-metadata
branch
2 times, most recently
from
9d2ebfe to
987e175
Compare
Upload all metadata from cachito, se we can avoid having extra queries for cachito endpoints and keep all data in koji STONEBLD-2655 Signed-off-by: Martin Basti <[email protected]>
MartinBasti
force-pushed
the
upload-all-cachito-metadata
branch
from
987e175 to
908fd3c
Compare
mkosiarc
reviewed
Aug 13, 2024
mkosiarc
approved these changes
Aug 13, 2024
|
@MartinBasti I see you created this PR against master, don't we want to use the feature_cachi2 branch? |
chmeliik
approved these changes
Aug 13, 2024
IIRC we wanted this change to go to master, because it's relevant for Cachito as well. Some projects (OpenScanHub) do rebuilds of OSBS builds and they depend on the env vars and config files from Cachito. When we decommission Cachito, they will no longer be able to use them. If we start uploading them to Brew now, they will be able to rebuild things up to half a year old (let's say we will decommission Cachito in half a year). |
mkosiarc
approved these changes
Aug 13, 2024
We don't need to havbe build_args as function anymore, it can be a property of RemoteSources Signed-off-by: Martin Basti <[email protected]>
MartinBasti
force-pushed
the
upload-all-cachito-metadata
branch
2 times, most recently
from
bbf5992 to
68216d8
Compare
chmeliik
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upload all metadata from cachito, se we can avoid having extra queries for cachito endpoints and keep all data in koji
STONEBLD-2655
Maintainers will complete the following section