cachi2: conversion function to cachi2 params #2092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinBasti
force-pushed
the
cachi2-params-conversion
branch
4 times, most recently
from
4bef433 to
25013bb
Compare
MartinBasti
requested review from
tkdchen,
ben-alkov,
rcerven,
mkosiarc and
chmeliik
mkosiarc
reviewed
Jul 17, 2024
atomic_reactor/utils/cachi2.py
Outdated
|
|
||
| Remote sources were orignally designed for cachito. Cachi2 is not a direct | ||
| fork but has lot of similarities. | ||
| However, some parameters must be updated to be compatible with cachi2.""" |
There was a problem hiding this comment.
Should we include more information about the parameters? Or are we expecting that we will always remove only the "include-git-dir" and "remove-unsafe-symlinks" flags?
There was a problem hiding this comment.
only these 2 flags as it's job for OSBS in future, and also that pkg manager Adam mentioned in #2092 (comment)
chmeliik
reviewed
Jul 17, 2024
atomic_reactor/utils/cachi2.py
Outdated
| packages = remote_source.get("packages", {}).get(pkg_manager, []) | ||
| packages = packages or [{"path": "."}] | ||
| for pkg in packages: | ||
| cachi2_packages.append({**{"type": pkg_manager}, **pkg}) |
There was a problem hiding this comment.
nipick: the intermediate {"type": "pkg_manager"} dict is unnecessary
{"type": pkg_manager, **pkg}
mkosiarc
approved these changes
Jul 18, 2024
MartinBasti
force-pushed
the
cachi2-params-conversion
branch
from
25013bb to
9e22006
Compare
|
Addressed comments, PTAL |
Conversion function that transforms remote_source into cachi2 params STONEBLD-2586 Signed-off-by: Martin Basti <[email protected]>
MartinBasti
force-pushed
the
cachi2-params-conversion
branch
from
9e22006 to
4dfb9e4
Compare
MartinBasti
merged commit f5b37e2
into
containerbuildsystem:feature_cachi2
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conversion function that transforms remote_source into cachi2 params
STONEBLD-2586
Maintainers will complete the following section