Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to React Native 0.76 and Expo 52 #2241

Merged
merged 12 commits into from
Dec 12, 2024
Merged

Upgrade to React Native 0.76 and Expo 52 #2241

merged 12 commits into from
Dec 12, 2024

Conversation

smaye81
Copy link
Member

@smaye81 smaye81 commented Dec 12, 2024

Fixes #2134

React Native 0.76 / Expo 52 have added full support for streaming. This updates our example to leverage this new functionality and remove notices/warnings that streaming is not yet supported.

$ npx expo-doctor                                                                                                                                                                        Enabled experimental React Native Directory checks. Unset the EXPO_DOCTOR_ENABLE_DIRECTORY_CHECK environment variable to disable this check.
✔ Check package.json for common issues
✔ Check Expo config for common issues
✔ Check for common project setup issues
✔ Check dependencies for packages that should not be installed directly
✔ Check for issues with Metro config
✔ Check npm/ yarn versions
✔ Check if the project meets version requirements for submission to app stores
✔ Validate packages against React Native Directory package metadata
✔ Check for app config fields that may not be synced in a non-CNG project
✔ Check Expo config (app.json/ app.config.js) schema
✔ Check that native modules do not use incompatible support packages
✔ Check for legacy global CLI installed locally
✔ Check native tooling versions
✔ Check that packages match versions required by installed Expo SDK
✔ Check that native modules use compatible support package versions for installed Expo SDK

Didn't find any issues with the project!

Web

image

Expo Go

image

iOS Simulator

image

Copy link
Member

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have been waiting years for this 🎉

react-native/app/index.tsx Outdated Show resolved Hide resolved
{
text: "What is your name?",
sender: "eliza",
},
]);

// Make the Eliza Service client
const abort = new AbortController();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure it's worth checking for this issue #2134 (comment). It has already been filed with a repro in expo/expo#33553, and it looks like a fix is underway. May be worth calling it out in a comment here, maybe the fix doesn't land for a while.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, just wanted you to see how I was testing it. I was going to remove it when ready for review. Will add a link to the code here instead.

// Make the Eliza Service client
const abort = new AbortController();

// Make the Eliza Service client using grpc-web transport.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're actually using the connect transport. Would be great to smoke test both with JSON and binary.

We also need to update README.md.

And https://connectrpc.com/docs/web/supported-browsers-and-frameworks

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with binary format also and can confirm all 3 areas work (web, simulator, expo go).

Updated README and also created connectrpc/connectrpc.com#244 for the docs.

@smaye81 smaye81 force-pushed the sayers/upgrade_rn_0.76 branch from cbf773c to c250c2a Compare December 12, 2024 19:51
@smaye81 smaye81 requested a review from timostamm December 12, 2024 19:52
@smaye81 smaye81 marked this pull request as ready for review December 12, 2024 19:52
smaye81 and others added 12 commits December 12, 2024 15:27
Signed-off-by: Steve Ayers <[email protected]>
Signed-off-by: Steve Ayers <[email protected]>
Signed-off-by: Steve Ayers <[email protected]>
Co-authored-by: Timo Stamm <[email protected]>
Signed-off-by: Steve Ayers <[email protected]>
Signed-off-by: Steve Ayers <[email protected]>
Signed-off-by: Steve Ayers <[email protected]>
Signed-off-by: Steve Ayers <[email protected]>
Co-authored-by: Timo Stamm <[email protected]>
Signed-off-by: Steve Ayers <[email protected]>
Signed-off-by: Steve Ayers <[email protected]>
Signed-off-by: Steve Ayers <[email protected]>
@smaye81 smaye81 force-pushed the sayers/upgrade_rn_0.76 branch from 6b7fc4a to 1fda40e Compare December 12, 2024 20:27
@smaye81 smaye81 requested a review from timostamm December 12, 2024 20:28
@smaye81 smaye81 merged commit 928b51e into main Dec 12, 2024
7 checks passed
@smaye81 smaye81 deleted the sayers/upgrade_rn_0.76 branch December 12, 2024 20:46
smaye81 added a commit to connectrpc/connectrpc.com that referenced this pull request Dec 12, 2024
React Native 0.76 and Expo 52 now offer full support for streaming. We
have an example of it running in our examples-es repo. See PR here:
connectrpc/examples-es#2241

This removes the FAQ about limited Fetch support from the docs.

Signed-off-by: Steve Ayers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to React-Native v0.76.0
2 participants