-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to React Native 0.76 and Expo 52 #2241
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have been waiting years for this 🎉
react-native/app/index.tsx
Outdated
{ | ||
text: "What is your name?", | ||
sender: "eliza", | ||
}, | ||
]); | ||
|
||
// Make the Eliza Service client | ||
const abort = new AbortController(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure it's worth checking for this issue #2134 (comment). It has already been filed with a repro in expo/expo#33553, and it looks like a fix is underway. May be worth calling it out in a comment here, maybe the fix doesn't land for a while.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, just wanted you to see how I was testing it. I was going to remove it when ready for review. Will add a link to the code here instead.
// Make the Eliza Service client | ||
const abort = new AbortController(); | ||
|
||
// Make the Eliza Service client using grpc-web transport. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're actually using the connect transport. Would be great to smoke test both with JSON and binary.
We also need to update README.md.
And https://connectrpc.com/docs/web/supported-browsers-and-frameworks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with binary format also and can confirm all 3 areas work (web, simulator, expo go).
Updated README and also created connectrpc/connectrpc.com#244 for the docs.
cbf773c
to
c250c2a
Compare
Signed-off-by: Steve Ayers <[email protected]>
Signed-off-by: Steve Ayers <[email protected]>
Signed-off-by: Steve Ayers <[email protected]>
Signed-off-by: Steve Ayers <[email protected]>
Signed-off-by: Steve Ayers <[email protected]>
Co-authored-by: Timo Stamm <[email protected]> Signed-off-by: Steve Ayers <[email protected]>
Signed-off-by: Steve Ayers <[email protected]>
Signed-off-by: Steve Ayers <[email protected]>
Signed-off-by: Steve Ayers <[email protected]>
Co-authored-by: Timo Stamm <[email protected]> Signed-off-by: Steve Ayers <[email protected]>
Signed-off-by: Steve Ayers <[email protected]>
Signed-off-by: Steve Ayers <[email protected]>
6b7fc4a
to
1fda40e
Compare
React Native 0.76 and Expo 52 now offer full support for streaming. We have an example of it running in our examples-es repo. See PR here: connectrpc/examples-es#2241 This removes the FAQ about limited Fetch support from the docs. Signed-off-by: Steve Ayers <[email protected]>
Fixes #2134
React Native 0.76 / Expo 52 have added full support for streaming. This updates our example to leverage this new functionality and remove notices/warnings that streaming is not yet supported.
Web
Expo Go
iOS Simulator