Fix Vite CJS build warning for Yarn and Vue #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smaye81
force-pushed
the
sayers/fix_vite_cjs_warning
branch
from
c891f0e to
e36f807
Compare
timostamm
approved these changes
Jul 31, 2024
|
Just noticed: The warning also appears for |
Signed-off-by: Steve Ayers <[email protected]>
Signed-off-by: Steve Ayers <[email protected]>
smaye81
force-pushed
the
sayers/fix_vite_cjs_warning
branch
from
c5b0798 to
721ec13
Compare
smaye81
changed the title
timostamm
approved these changes
Jul 31, 2024
Comment on lines
+5
to
+7
| // Note that vue scaffolds a cypress config with a .ts extension, but this doesn't | ||
| // work with ESM modules. Renaming this file to have a .js extension fixes the issue. | ||
| // See: https://github.com/cypress-io/cypress/issues/23552 |
There was a problem hiding this comment.
npm create vue@latest actually does scaffold a .ts file, and it doesn't use the webpack-preprocessor.
I think we might only need the webpack-preprocessor for .js import extensions. We don't add them with v2 anymore, so I think we can simplify this example a lot, and reduce the diff to the default setup. But I don't think it's worth doing that here, in v1.
smaye81
added a commit
that referenced
this pull request
Aug 12, 2024
Fixes #1721 This fixes the warning about Vite's deprecated CJS build in the `react/yarn-pnp` and `vue` projects by converting them to an ESM module. Previously, they were both CJS, most likely due to a simple oversight. With Vue, it also involved renaming the Cypress config to be a `.js` file. Vue scaffolds Cypress config files to be a `.ts` file, which in turn does not work with ESM modules. See [this issue](cypress-io/cypress#23552) for more info. For more info on the Vite CJS message: https://vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated --------- Signed-off-by: Steve Ayers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1721
This fixes the warning about Vite's deprecated CJS build in the
react/yarn-pnpandvueprojects by converting them to an ESM module. Previously, they were both CJS, most likely due to a simple oversight.With Vue, it also involved renaming the Cypress config to be a
.jsfile. Vue scaffolds Cypress config files to be a.tsfile, which in turn does not work with ESM modules. See this issue for more info.For more info on the Vite CJS message: https://vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated