Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to v2 #479

Merged
merged 45 commits into from
Nov 4, 2024
Merged

Switch to v2 #479

merged 45 commits into from
Nov 4, 2024

Conversation

timostamm
Copy link
Member

@timostamm timostamm commented Nov 4, 2024

This merges the branch v2 into main, with a note at the top of the README (added in #477):

Important

You are looking at the release candidate for version 2. For the current stable version, see the branch v1.

Related:

srikrsna-buf and others added 30 commits September 23, 2024 18:02
This adds a function that can apply a static key to a transport, useful
when considering SSR contexts where the transport on the client is not
the same transport as on the server.

---------

Signed-off-by: Timo Stamm <[email protected]>
Signed-off-by: Paul Sachs <[email protected]>
Co-authored-by: Timo Stamm <[email protected]>
As discussed in [discussion
thread](#449 (comment)),
we need to be explicit about cardinality of query keys.

---------

Signed-off-by: Paul Sachs <[email protected]>
paul-sachs and others added 15 commits October 10, 2024 14:38
## What's Changed

Peer deps update


**Full Changelog**:
v2.0.0-beta.1...v2.0.0-beta.2

Signed-off-by: Paul Sachs <[email protected]>
## What's Changed

This is a release candidate for version 2.

**Full Changelog**:
v2.0.0-beta.2...v2.0.0-rc.1

---------

Signed-off-by: Paul Sachs <[email protected]>
## What's Changed

Fix issue with npm release

**Full Changelog**:
v2.0.0-rc.1...v2.0.0-rc.2

Signed-off-by: Paul Sachs <[email protected]>
…en when could be passed skipToken (#469)

In order to use createQueryOptions with recent versions of react-query
and `useSuspenseQuery`, we need to make sure createQueryOptions isn't
passing `skipToken` as a potential type when the input type couldn't be
skipToken. This is because the typings for `useSuspenseQuery` now
disallow skipping (which was always the case, just was not reflected in
the types.)

To fix this, we overload the `createQueryOptions` call to indicate with
it's types that it will only return a skipToken when input is a
skipToken.

Signed-off-by: Paul Sachs <[email protected]>
…ries (#470)

If we customize the queryKeyHashFn, it prevents
`queryClient.setQueryData` from finding the query in question, unless
the `queryClient` was initialized with the same queryKeyHashFn. It would
be nice to be able to customize this on a per query basis but [it
doesn't seem to be an accepted
approach](TanStack/query#2352 (comment)).

---------

Signed-off-by: Paul Sachs <[email protected]>
A dedicated connect-query-core package makes it much easier to integrate
non-react integrations.

The public API of `@connectrpc/connect-query` hasn't changed at all, all
the same methods and types are exposed, we've just separated them into a
distinct package that gets reexported from `@connectrpc/connect-query`.

This change allows others to depend on connect-query without necessarily
depending on react and react-query.

Partially addresses #324

---------

Signed-off-by: Paul Sachs <[email protected]>
Co-authored-by: Timo Stamm <[email protected]>
Copy link
Collaborator

@paul-sachs paul-sachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 we just need to signed commit instead to satisfy the cursed DCO

@timostamm
Copy link
Member Author

The bot reports 36 commits with missing or unexpected sign-off. I don't think it handles squash-merged PRs properly, and I don't think it would be right if I signed commits authored by others.

Since this only merges PRs that have previously passed DCO, I think we're good.

@timostamm timostamm merged commit 70bc94b into main Nov 4, 2024
7 of 8 checks passed
@timostamm timostamm deleted the tstamm/switch-to-v2 branch November 4, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants