Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set User-Agent header in connect-web #912

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Conversation

srikrsna-buf
Copy link
Member

@srikrsna-buf srikrsna-buf commented Nov 7, 2023

Don't set User-Agent header in connect-web. Not all browsers allow updating user agent header. See #878. We update connect-web to remove the header and continue to set in connect-node.

Closes #878

Copy link
Member

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please update the PR description with details.

@srikrsna-buf srikrsna-buf merged commit 24bcfb2 into main Nov 7, 2023
5 checks passed
@srikrsna-buf srikrsna-buf deleted the sk/user-agent branch November 7, 2023 13:21
This was referenced Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

createConnectTransport replacing user-agent header on Safari and Firefox, but not chrome
2 participants