Add additional options for generating imports #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@timostamm I added |
smaye81
force-pushed
the
sayers/add_addl_opts
branch
from
741556d to
363c6b1
Compare
timostamm
reviewed
Dec 5, 2024
timostamm
approved these changes
Dec 5, 2024
Signed-off-by: Steve Ayers <[email protected]>
Signed-off-by: Steve Ayers <[email protected]>
Signed-off-by: Steve Ayers <[email protected]>
Co-authored-by: Timo Stamm <[email protected]> Signed-off-by: Steve Ayers <[email protected]>
Co-authored-by: Timo Stamm <[email protected]> Signed-off-by: Steve Ayers <[email protected]>
smaye81
force-pushed
the
sayers/add_addl_opts
branch
from
83c4a6b to
8fd595b
Compare
smaye81
added a commit
that referenced
this pull request
Jan 6, 2025
* Add additional docs on options Signed-off-by: Steve Ayers <[email protected]> * Remove WKT Signed-off-by: Steve Ayers <[email protected]> * Format Signed-off-by: Steve Ayers <[email protected]> * Update MIGRATING.md Co-authored-by: Timo Stamm <[email protected]> Signed-off-by: Steve Ayers <[email protected]> * Update MIGRATING.md Co-authored-by: Timo Stamm <[email protected]> Signed-off-by: Steve Ayers <[email protected]> --------- Signed-off-by: Steve Ayers <[email protected]> Co-authored-by: Timo Stamm <[email protected]>
smaye81
added a commit
that referenced
this pull request
Jan 8, 2025
* Add additional docs on options Signed-off-by: Steve Ayers <[email protected]> * Remove WKT Signed-off-by: Steve Ayers <[email protected]> * Format Signed-off-by: Steve Ayers <[email protected]> * Update MIGRATING.md Co-authored-by: Timo Stamm <[email protected]> Signed-off-by: Steve Ayers <[email protected]> * Update MIGRATING.md Co-authored-by: Timo Stamm <[email protected]> Signed-off-by: Steve Ayers <[email protected]> --------- Signed-off-by: Steve Ayers <[email protected]> Co-authored-by: Timo Stamm <[email protected]> Signed-off-by: Steve Ayers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including imports is not enabled by default in the Buf CLI. As a result, users have been getting tripped up on generating code when they have dependencies on protovalidate.
This adds some additional guidance in our generating code docs to make sure they include imports since these should essentially always be included when generating with Protobuf-ES.