Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeORM 버그 fix 및 entity 설정 #47

Merged
merged 2 commits into from
Nov 21, 2019
Merged

TypeORM 버그 fix 및 entity 설정 #47

merged 2 commits into from
Nov 21, 2019

Conversation

kyungrae
Copy link
Collaborator

@kyungrae kyungrae commented Nov 21, 2019

관련 이슈

#4

Description and Motivation

  1. typescript absolute import 문을 사용한 결과 compile 후 entity 경로를 찾지 못하는 이슈가 발생했다. 아직 tsconfig 파일에 익숙하지 않아 임시로 상대경로를 사용하기로 했다.
  2. 채팅을 위해 필요한 profile, room, post entity를 생성했다.

Types of changes

  • Docs change
  • dependency upgrade
  • refactoring
  • Bug fix
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Review

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

why: 가독성을 위해 absolute import을 이용했지만  compile 후 entity를 찾지 못해 상대 경로를 사용
why: 실시간 채팅에 필요한 최소한의 entity를 설계함
@raccoonback raccoonback requested review from raccoonback and removed request for raccoonback November 21, 2019 09:41
@kyungrae kyungrae merged commit 2da37bd into develop Nov 21, 2019
@GiPyoo GiPyoo deleted the typeorm-entity branch November 27, 2019 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant