td-layout: load payload image into physical memory space #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaojiaqi7
force-pushed
the
0320/load_payload_image_into_physical_memory
branch
4 times, most recently
from
b72f137 to
d39abbb
Compare
Firmware volume header has limitation on the size of the data inside which needs to be smaller than maximum value of u24 (0xffffff). To lift the restriction, FV header is removed for payload images as it is not mandatory. Signed-off-by: Jiaqi Gao <[email protected]>
At runtime, if td-shim image is not loaded into memory 1:1, the metadata offset at firmware_end - 0x20 will be invalid because it is the offset from the beginning of the image. The value inside the OVMF GUID table is the offset from the end of the image which is not changed after loading into memory. Signed-off-by: Jiaqi Gao <[email protected]>
jyao1
reviewed
Mar 22, 2024
| | FREE | (0x1000) 4 KB | ||
| +----------------------------------------+ <- 0x82000 | ||
| | PAYLOAD | (0xC2D000) 12.18 MB | ||
| | FREE | (0x0) 0 B |
jyao1
reviewed
Mar 22, 2024
td-layout/src/memslice.rs
Outdated
| @@ -39,7 +39,7 @@ impl SliceType { | |||
| match self { | |||
| SliceType::Config => "Config", | |||
| SliceType::TdHob => "TdHob", | |||
| SliceType::ShimPayload => "ShimPayload", | |||
| SliceType::PayloadImage => "PayloadImage", | |||
jyao1
reviewed
Mar 22, 2024
| @@ -4,7 +4,7 @@ | |||
| "TempStack": "0x020000", | |||
| "TempHeap": "0x020000", | |||
| "Metadata": "0x001000", | |||
| "Payload": "0xC2D000", | |||
| "Payload": "0xC2E000", | |||
There was a problem hiding this comment.
why we need to enlarge for load into physical memory?
jyao1
reviewed
Mar 22, 2024
| 0x984a, | ||
| 0x4798, | ||
| [0x86, 0x5e, 0x46, 0x85, 0xa7, 0xbf, 0x8e, 0xc2], | ||
| ); |
The old implementation loads the payload image into ROM space which limited the size of the payload to be smaller than 16MiB. The previous layout 1:1 maps the image to the ROM space. As we move payload to physical memory space, ROM layout and image layout will be different in td-layout-config tool. The default image config is adjusted to generate a 16MiB image by default. Signed-off-by: Jiaqi Gao <[email protected]>
Payload image is loaded into physical memory space so the functions under memslice are updated and the metadata is updated. Signed-off-by: Jiaqi Gao <[email protected]>
gaojiaqi7
force-pushed
the
0320/load_payload_image_into_physical_memory
branch
from
d39abbb to
1b71a3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old implementation loads the payload image into ROM space which limited the size of the payload to be smaller than 16MiB.
td-layout-configtool.Related issue: #665