-
Notifications
You must be signed in to change notification settings - Fork 22
Support for PKCS11 #3
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Chris Porter <[email protected]>
Signed-off-by: Arron Wang <[email protected]>
Signed-off-by: Arron Wang <[email protected]>
Signed-off-by: Chris Porter <[email protected]>
Signed-off-by: Chris Porter <[email protected]>
Signed-off-by: Chris Porter <[email protected]>
Initial implementation for module spec/config/helper Signed-off-by: Chris Porter <[email protected]>
Initial implementation for module spec/config/helper Signed-off-by: R. Jantz <[email protected]>
Signed-off-by: Chris Porter <[email protected]>
Signed-off-by: Chris Porter <[email protected]>
Signed-off-by: Chris Porter <[email protected]>
Signed-off-by: Chris Porter <[email protected]>
Signed-off-by: Chris Porter <[email protected]>
…ganization Signed-off-by: Chris Porter <[email protected]>
Signed-off-by: Chris Porter <[email protected]>
Signed-off-by: Chris Porter <[email protected]>
Signed-off-by: rudy jantz <[email protected]>
Signed-off-by: rudy jantz <[email protected]>
Signed-off-by: rudy jantz <[email protected]>
Signed-off-by: rudy jantz <[email protected]>
Signed-off-by: rudy jantz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At some point when this is ready to merge, it may be good for @stefanberger to take a quick look through as well as he was the main author of the PKCS11 component.
@@ -10,3 +10,11 @@ edition = "2018" | |||
|
|||
[dependencies] | |||
anyhow = ">=1.0" | |||
pkcs11 = ">=0.5.0" | |||
pkcs11-uri = ">=0.1.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stefanberger are these libraries using the same standard for PKCS11 URIs? This library says it's implementing RFC 7512, so it seems like there shouldn't be any issue here, but deferring to your opinion on the intricacies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following this page here it does:
PKCS#11 URI
Bare bones implementation of the RFC 7512 URI scheme for locating keys and other PKCS#11 objects.
This library is patched together from existing libraries, namely pkcs11, uriparse and percent-encoding, and is a work in progress.
So this library seems to want to do the same as mine does. Differences may be in the details.
Signed-off-by: rudy jantz <[email protected]>
Signed-off-by: rudy jantz <[email protected]>
Signed-off-by: rudy jantz <[email protected]>
Signed-off-by: rudy jantz <[email protected]>
@lumjjb @fitzthum this pkcs11 support never got merged in August, but I want to find out if it's still wanted/needed in ocicrypt-rs. If so, what's a good next set of steps? There's a lot of code here. I can confirm that the happy-path test replicated from golang's ocicrypt works. Also, what is the slack URL for discussing ocicrypt development? I cannot seem to find it. Lastly, testing environment is a problem in this PR, and I'm open to suggestions. I disabled a test that's unrelated to my PR but which was breaking the automatic github push checkers (caf91a4). I think this is due to an environment variable problem from here: |
@rudyjantz I think we have an ocicrypt channel in the Kata slack workspace. |
@portersrc (or any other commenter) - please could you give an update on the status of this PR. It's pretty huge meaning it's going to be difficult to land I fear. Also, could these 131 commits be squashed down to... 1? 😄 |
"give an update": I need to fix the latest conflicts. I will look at it next week after Tuesday. "it's pretty huge, hard to land": Agreed. I intentionally followed the pkcs11 support in the (golang) ocicrypt repo closely when porting, thinking this was least risk. I glanced at issue confidential-containers/guest-components#182 today, and it looks like this project has made good progress. This feature might be a nice add. I'm OK with closing or fixing any and all requests before merging. "131 commits squashed to 1": I can do that before a merge, no problem. |
Signed-off-by: chris porter <[email protected]>
Signed-off-by: chris porter <[email protected]>
Signed-off-by: chris porter <[email protected]>
Signed-off-by: chris porter <[email protected]>
…st return false for now) Signed-off-by: chris porter <[email protected]>
Signed-off-by: chris porter <[email protected]>
Signed-off-by: chris porter <[email protected]>
…ha1 now instead of sha256 Signed-off-by: chris porter <[email protected]>
Signed-off-by: chris porter <[email protected]>
Signed-off-by: chris porter <[email protected]>
Signed-off-by: chris porter <[email protected]>
Signed-off-by: chris porter <[email protected]>
Signed-off-by: chris porter <[email protected]>
Signed-off-by: chris porter <[email protected]>
The "nightly" github job may have a small bug which is causing it to fail. Here's its error:
But I've already made this change here. Note that clippy modifies the keyprovider.rs file, so what may be happening is a prior github job (i.e. stable or beta) modifies the source, which then gets (incorrectly) reused in the nightly job. |
@jodh-intel |
Initial pkcs11 support for ocicrypt-rs, ported from ocicrypt's golang version.