Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen grpcio dependencies to avoid opentelemetry installing issues #1228

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Redna
Copy link

@Redna Redna commented Dec 16, 2024

I am unable to install a project with newer opentelemetry dependencies:

ERROR: Cannot install api because these package versions have conflicting dependencies.

The conflict is caused by:
deepeval 2.0.5 depends on grpcio==1.60.1
opentelemetry-exporter-otlp-proto-grpc 1.28.2 depends on grpcio<2.0.0 and >=1.63.2

While open telemetry dependencies are defined as follows

setup.py

        "opentelemetry-api>=1.24.0,<2.0.0",
        "opentelemetry-sdk>=1.24.0,<2.0.0",
        "opentelemetry-exporter-otlp-proto-grpc>=1.24.0,<2.0.0",

pyproject.toml

    opentelemetry-api = "^1.24.0"
    opentelemetry-sdk = "^1.24.0"
    opentelemetry-exporter-otlp-proto-grpc = "^1.24.0"

grpcio must be exactly 1.60.1 which causes conflicts for opentelemetry > 1.28.0 installations.

Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
evals-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 10:00am

@penguine-ip
Copy link
Contributor

Hey @Redna I believe grpc was restricted to prevent a really weird error I was encountering, let me get back to you on what the error is and see if we can resolve it firstt

@lwj5 lwj5 mentioned this pull request Dec 30, 2024
@Redna
Copy link
Author

Redna commented Jan 8, 2025

Hey @Redna I believe grpc was restricted to prevent a really weird error I was encountering, let me get back to you on what the error is and see if we can resolve it firstt

In the meantime, have you had a chance to take a look at it?
Thanks!

@penguine-ip
Copy link
Contributor

@Redna in all honestly I forgot, I'll loosen it and run it by end of day today though, please feel free to ping me if theres no word on my side to get this over the line

@lwj5
Copy link

lwj5 commented Jan 15, 2025

@penguine-ip hope you can help ship this.

This is also preventing installation on python 3.13 as only grpcio versions >=1.67 works

@penguine-ip
Copy link
Contributor

Hey @Redna and @lwj5 i found the error i was talking about which stopped me from accepting this PR

WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
E0000 00:00:1736925400.856439 1273041 init.cc:232] grpc_wait_for_shutdown_with_timeout() timed out.

This prints out at the end of every evaluation which is really annoying experience for users. This happens in 1.69 which is the one that installs when i do "^1.6.0". As a result I'm upgrading it to "1.67.1" instead which doesn't cause the problem but it upgraded as requested. Hope this solves the problem?

New release is 2.1.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants