Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing "skip_on_missing_params" #1065

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Fix missing "skip_on_missing_params" #1065

merged 1 commit into from
Oct 8, 2024

Conversation

AdrienDuff
Copy link

This pull request addresses a TypeError raised when evaluate() is called with show_indicator=False.

The error, "TypeError: a_execute_llm_test_cases() missing 1 required positional argument: 'skip_on_missing_params'", occurs because the skip_on_missing_params argument is missing from the a_execute_llm_test_cases() function call under these conditions.

This commit provides the missing argument.

Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
evals-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 3:13pm

@penguine-ip penguine-ip merged commit aa88af4 into confident-ai:main Oct 8, 2024
2 of 5 checks passed
@AdrienDuff AdrienDuff deleted the fix-missing-param branch October 9, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants