Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for PyPy3.9 #2

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update pypy38.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/7146847969, please use this URL for debugging.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@flferretti
Copy link
Contributor

flferretti commented Dec 11, 2023

Probably ctypes.pythonapi needs to be imported separately as from ctypes import pythonapi. Some python version have similar problems with other ctypes modules (see tensorflow/lucid#286)

@traversaro
Copy link
Contributor

Probably ctypes.pythonapi needs to be imported separately as from ctypes import pythonapi. Some python version have similar problems with other ctypes modules (see tensorflow/lucid#286)

I guess ctypes.pythonapi is simply not available in PyPy, see https://doc.pypy.org/en/latest/discussion/ctypes-implementation.html#discussion-and-limitations. Probably there is little we can do at the packaging level at this point. fyi @conda-forge/help-pypy

@mattip
Copy link

mattip commented Dec 11, 2023

It is too hard for PyPy to export the pythonapi interface. I am not sure what to suggest to upstream. It seems this is used to create a dlpack interface. Is there no c-extension code in warp?

@traversaro traversaro added the help wanted Extra attention is needed label Dec 12, 2023
@traversaro
Copy link
Contributor

It is too hard for PyPy to export the pythonapi interface.

Yes, I imagined.

I am not sure what to suggest to upstream. It seems this is used to create a dlpack interface. Is there no c-extension code in warp?

To be completely honest we (me and @flferretti) are not directly interested in pypy support, so if anyone is interested in pypy support for warp-lang feel free to chime in on this (I guess also interacting with upstream on this). To avoid misunderstandings, I mark this PR with help wanted .

@regro-cf-autotick-bot
Copy link
Contributor Author

I see that this PR has conflicts, and I'm the only committer. I'm going to close this PR and will make another one as appropriate. This was generated by https://github.com/regro/cf-scripts/actions/runs/7637781755

@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-pypy38-0-1_he88fdb branch January 24, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants