Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cmt #283

Merged
merged 2 commits into from
Apr 6, 2016
Merged

Add cmt #283

merged 2 commits into from
Apr 6, 2016

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented Apr 6, 2016

Apparently my description got wiped out when I moved it on ZenHub boards. So, I'm re-writing based on what I remember. 😢

We have tried to package cmt. This is a brand new recipe. A number of issues were found with the latest release. These have all been submitted upstream. All patches that made sense have been submitted upstream. There is one workaround patch (compiler change for Mac), which has not been submitted upstream. However, an issue has been opened to discuss changes that would make it unnecessary. Below is a list of either PRs (with issues referenced) or issues (if no PR was submitted). Also, a list of otherwise related issues has been compiled below.

Patches:

Related issues:

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly conda-forge-admin automated user.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cmt) and found it was in an excellent condition.

@jakirkham jakirkham force-pushed the add_cmt branch 5 times, most recently from c1bb19a to 68ee892 Compare April 6, 2016 17:10
@jakirkham
Copy link
Member Author

It seems some of the tests may be too intense for Circle CI. We may need to skip some of them on that platform.

@jakirkham jakirkham changed the title WIP: Add cmt Add cmt Apr 6, 2016
@jakirkham
Copy link
Member Author

Anybody have feedback here? Personally, I am ok with this, but maybe there are things that could be improved.

@jakirkham
Copy link
Member Author

@ocefpaf, thoughts?

If nothing too serious, I am thinking I will merge this once CI passes. It takes awhile to build and test so I don't want to cut into the build queue time at staged-recipes.

@jakirkham jakirkham merged commit 80469a2 into conda-forge:master Apr 6, 2016
@pelson pelson removed the in progress label Apr 6, 2016
@jakirkham jakirkham deleted the add_cmt branch April 6, 2016 19:56
@jakirkham
Copy link
Member Author

Feedback welcome at the feedstock.

@ocefpaf
Copy link
Member

ocefpaf commented Apr 6, 2016

👍

@jakirkham
Copy link
Member Author

Sorry, was pretty fast on merging.

Glad to hear you approve though. 😄

@jakirkham
Copy link
Member Author

@lucastheis, we are adding cmt to conda-forge. This is the community packaging system for use with conda. Packages built here are built with CI and deployed to the conda-forge channel automatically after committing on master of a feedstock (a repo with the recipe plus automatically maintained CI scripts). Eventually, packages submitted here will be included in the defaults channel after some auditing process as mentioned. If there is anything here that you see is off or needs to be fixed, please let me know. If you would like to have access to the cmt feedstock/recipe, I would happily add you to the maintainers list so you can have commit privileges for this recipe. This would be useful for updating the version for instance. Thanks again for working on such a useful library.

As a side note, there were a few testing issues I ran into, which I have filed issues for. Also, all the patches I have here have been submitted as PRs. Once these are resolved, it would be nice to see a fresh release on master so we can get Python 3.x support and fixes to these issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants