-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cmt #283
Add cmt #283
Conversation
Hi! This is the friendly conda-forge-admin automated user. I just wanted to let you know that I linted all conda-recipes in your PR ( |
c1bb19a
to
68ee892
Compare
It seems some of the tests may be too intense for Circle CI. We may need to skip some of them on that platform. |
Anybody have feedback here? Personally, I am ok with this, but maybe there are things that could be improved. |
@ocefpaf, thoughts? If nothing too serious, I am thinking I will merge this once CI passes. It takes awhile to build and test so I don't want to cut into the build queue time at staged-recipes. |
Feedback welcome at the feedstock. |
👍 |
Sorry, was pretty fast on merging. Glad to hear you approve though. 😄 |
@lucastheis, we are adding As a side note, there were a few testing issues I ran into, which I have filed issues for. Also, all the patches I have here have been submitted as PRs. Once these are resolved, it would be nice to see a fresh release on |
Apparently my description got wiped out when I moved it on ZenHub boards. So, I'm re-writing based on what I remember. 😢
We have tried to package
cmt
. This is a brand new recipe. A number of issues were found with the latest release. These have all been submitted upstream. All patches that made sense have been submitted upstream. There is one workaround patch (compiler change for Mac), which has not been submitted upstream. However, an issue has been opened to discuss changes that would make it unnecessary. Below is a list of either PRs (with issues referenced) or issues (if no PR was submitted). Also, a list of otherwise related issues has been compiled below.Patches:
Related issues: