-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gdbm support (python 3.7) #195
base: main
Are you sure you want to change the base?
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@@ -104,6 +106,10 @@ requirements: | |||
#- vs2015_runtime # [win] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be including gdbm
at runtime?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GOod question. My vote is no to keep GPL library out of the core dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An other reason would be to keep the python package lean. I'm sure there are many other options that could be added, but not everybody might need them. Since it wasn't really creating issues before, I assume that it is OK as is.
087aa0c
to
cca9e54
Compare
Have restarted CIs now that |
I noticed pypy was built with gdbm. Do we need to defender it? |
OMG. So sorry. I clicked the wrong button ... |
All good. Possibly. Maybe we should raise an issue on the PyPy feedstocks and see. |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to re-render for you, but it looks like there was nothing to do. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Rather than creating a build of Python with the gdbm module what if a separate package was created that contained the This requires that the code that build be extension be extracted out the setup.py file in the Python source code but I'd be happy to help with this. |
@jjhelmus I would be in favor of that Honestly, I was just going to create the same python package but omit the strict dependency on the gdbm package. But to your idea, could we simply create a split package where by one output, |
Any update on this effort? :) |
Requires conda-forge/staged-recipes#6681
Closes #125
I got stuck doing something that required gdbm. I think that gdbm is required, so I decided to compile it.
I'll rerender after the package review to avoid noise in the commit.
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)