Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to v3.3.0; also removing old patches. #63

Merged
merged 7 commits into from
Nov 1, 2024

Conversation

pp-mo
Copy link
Contributor

@pp-mo pp-mo commented Oct 31, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@pp-mo
Copy link
Contributor Author

pp-mo commented Oct 31, 2024

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • No valid build backend found for Python recipe for package cf-units using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.
  • PyPI default URL is now pypi.org, and not pypi.io. You may want to update the default source url.

@pp-mo
Copy link
Contributor Author

pp-mo commented Oct 31, 2024

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@pp-mo
Copy link
Contributor Author

pp-mo commented Oct 31, 2024

Note : I presume removing the old patches is now the right thing to do ?

At least, if it seems to work, then I know no better.

  • There is a note about removing the "backport_368" here (it's about Python 3.12 ?)
  • I can't work out if the other one is still needed (it's about numpy 2)
    Possibly, given the current failures ?

@ocefpaf
Copy link
Member

ocefpaf commented Oct 31, 2024

  • There is a note about removing the "backport_368" here (it's about Python 3.12 ?)

That one was merged. See SciTools/cf-units#368
The other one was not but I believe someone made the proper changes in another PR. If not, it is just https://github.com/SciTools/cf-units/pull/427/files#diff-ef037721b197e608853e2e25efd260fb32471e5e861083e0c2996fecbde976d6 that is needed.

  • I can't work out if the other one is still needed (it's about numpy 2)
    Possibly, given the current failures ?

Nope. Just the name. PyPI is no longer accepting - and _ as the same thing in URLs.

@ocefpaf
Copy link
Member

ocefpaf commented Oct 31, 2024

@conda-forge-admin, please rerender

@ocefpaf ocefpaf merged commit 1c2fe17 into conda-forge:main Nov 1, 2024
27 checks passed
@pp-mo
Copy link
Contributor Author

pp-mo commented Nov 1, 2024

Thanks @ocefpaf !
I hadn't seen what you did, so I made a fix, which then conflicted with yours !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants