Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix shared model manager warning #2044

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

fix shared model manager warning #2044

wants to merge 5 commits into from

Commits on Nov 8, 2023

  1. fix shared model manager warning 

    afterAttachToDocument is called
before the shared model manager is ready.
This then causes a warning when a shared model is accessed
by a tile using afterAttachToDocument.
    @scytacki
    scytacki committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    cecb03a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix-shared-model-warning

    @scytacki
    scytacki authored Nov 8, 2023
    Configuration menu
    Copy the full SHA
    8d6a959 View commit details
    Browse the repository at this point in the history

  3. fixup comment

    @scytacki
    scytacki committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    1310d9b View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. update the comment.

    @scytacki
    scytacki committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    b851dfe View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. WIP notes about simplifying shared model sync 

    These notes documents how tiles are using afterAttach.
They also describe a way to unify the updateAfterSharedModelChanges
and the way afterAttach is being used.
    @scytacki
    scytacki committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    f292868 View commit details
    Browse the repository at this point in the history