Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drag of dot with zero value in dot plot #1632

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kswenson
Copy link
Member

@kswenson kswenson commented Nov 16, 2024

[PT-188514748]

The fix replaces || with ??, where the former doesn't handle zero values correctly.

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.66%. Comparing base (c59d12e) to head (05e38f3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...c/components/graph/hooks/use-dot-plot-drag-drop.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1632      +/-   ##
==========================================
+ Coverage   85.57%   85.66%   +0.08%     
==========================================
  Files         600      600              
  Lines       30414    30414              
  Branches     8355     7779     -576     
==========================================
+ Hits        26027    26053      +26     
- Misses       4066     4206     +140     
+ Partials      321      155     -166     
Flag Coverage Δ
cypress 75.16% <0.00%> (+0.11%) ⬆️
jest 52.59% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Nov 16, 2024

codap-v3    Run #5250

Run Properties:  status check passed Passed #5250  •  git commit 05e38f3f8f: fix: drag of dot with zero value in dot plot
Project codap-v3
Branch Review 188514748-fix-drag-zero-value
Run status status check passed Passed #5250
Run duration 05m 56s
Commit git commit 05e38f3f8f: fix: drag of dot with zero value in dot plot
Committer Kirk Swenson
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 35
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 220
View all changes introduced in this branch ↗︎

@kswenson kswenson marked this pull request as ready for review November 16, 2024 08:18
Copy link
Contributor

@bfinzer bfinzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants