-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: drag of dot with zero value in dot plot #1632
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1632 +/- ##
==========================================
+ Coverage 85.57% 85.66% +0.08%
==========================================
Files 600 600
Lines 30414 30414
Branches 8355 7779 -576
==========================================
+ Hits 26027 26053 +26
- Misses 4066 4206 +140
+ Partials 321 155 -166
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
codap-v3 Run #5250
Run Properties:
|
Project |
codap-v3
|
Branch Review |
188514748-fix-drag-zero-value
|
Run status |
Passed #5250
|
Run duration | 05m 56s |
Commit |
05e38f3f8f: fix: drag of dot with zero value in dot plot
|
Committer | Kirk Swenson |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
35
|
Skipped |
0
|
Passing |
220
|
View all changes introduced in this branch ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻LGTM
[PT-188514748]
The fix replaces
||
with??
, where the former doesn't handle zero values correctly.