fix: handling of hidden/minimized tiles #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1630 +/- ##
===========================================
+ Coverage 67.88% 85.65% +17.77%
===========================================
Files 600 600
Lines 30405 30413 +8
Branches 8351 8293 -58
===========================================
+ Hits 20639 26049 +5410
+ Misses 9611 4045 -5566
- Partials 155 319 +164
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
codap-v3
|
||||||||||||||||||||||||||||
| Project |
codap-v3
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 01m 52s |
| Commit |
|
| Committer | eireland |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
3
|
| View all changes introduced in this branch ↗︎ | |
kswenson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[PT-188570070]
#1622 addressed the case of minimized tiles, but did not properly capture the relationship between hidden and minimized tiles. The document in the PT story has a case table that has been minimized and hidden. In v2, when such a tile is shown/unhidden it is also unminimized. In other words, when a hidden tile is shown, its prior minimized/unminimized state is ignored, which is equivalent to saying that a tile cannot be both hidden and minimized. Therefore, we implement this rule at the model level, so that we don't have to find all clients that show hidden tiles (Calculator button in tool shelf, close button of certain tiles, table menu items, etc.).