-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
182991523 date type precision menu #1620
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1620 +/- ##
==========================================
- Coverage 85.64% 83.97% -1.67%
==========================================
Files 599 601 +2
Lines 30170 30384 +214
Branches 7708 7764 +56
==========================================
- Hits 25838 25516 -322
- Misses 4177 4713 +536
Partials 155 155
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
codap-v3 Run #5207
Run Properties:
|
Project |
codap-v3
|
Branch Review |
main
|
Run status |
Passed #5207
|
Run duration | 02m 03s |
Commit |
1c55fc4a94: 182991523 date type precision menu (#1620)
|
Committer | Evangeline Ireland |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
3
|
View all changes introduced in this branch ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good -- I added a commit which cleaned up a few things. Make sure I didn't break anything before you merge. 😉
Adds a different precision menu when attribute type is date.
Implements showing the correct precision when user changes precision without having to change attribute type.