Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

182991523 date type precision menu #1620

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Conversation

eireland
Copy link
Contributor

Adds a different precision menu when attribute type is date.

Implements showing the correct precision when user changes precision without having to change attribute type.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 79.54545% with 9 lines in your changes missing coverage. Please review.

Project coverage is 83.97%. Comparing base (2b26bad) to head (985c1ec).
Report is 60 commits behind head on main.

Files with missing lines Patch % Lines
...attribute-menu/edit-attribute-properties-modal.tsx 72.00% 7 Missing ⚠️
v3/src/components/case-table/use-rows.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1620      +/-   ##
==========================================
- Coverage   85.64%   83.97%   -1.67%     
==========================================
  Files         599      601       +2     
  Lines       30170    30384     +214     
  Branches     7708     7764      +56     
==========================================
- Hits        25838    25516     -322     
- Misses       4177     4713     +536     
  Partials      155      155              
Flag Coverage Δ
cypress 72.80% <72.97%> (-2.36%) ⬇️
jest 52.63% <61.36%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Nov 14, 2024

codap-v3    Run #5207

Run Properties:  status check passed Passed #5207  •  git commit 1c55fc4a94: 182991523 date type precision menu (#1620)
Project codap-v3
Branch Review main
Run status status check passed Passed #5207
Run duration 02m 03s
Commit git commit 1c55fc4a94: 182991523 date type precision menu (#1620)
Committer Evangeline Ireland
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 3
View all changes introduced in this branch ↗︎

Copy link
Member

@kswenson kswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good -- I added a commit which cleaned up a few things. Make sure I didn't break anything before you merge. 😉

@eireland eireland merged commit 1c55fc4 into main Nov 15, 2024
12 of 17 checks passed
@eireland eireland deleted the 182991523-date-type-precision-menu branch November 15, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants