fix: bivariate semi-aggregates (linRegrPredicted, linRegrResidual) re…

…spect filter argument
concord-consortium · Nov 15, 2024 · 877390c · 877390c
1 parent 46b4470
commit 877390c
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/v3/src/models/formula/functions/bivariate-stats-functions.ts b/v3/src/models/formula/functions/bivariate-stats-functions.ts
@@ -134,7 +134,8 @@ function evaluateRawLinearRegressionSemiAggregate(fn: (lsr: ValidLSRResult, x: n
     scope.withLocalContext(() => {
       const [xIsValid, x] = checkNumber(evaluateNode(xArg, scope))
       const [yIsValid, y] = checkNumber(evaluateNode(yArg, scope))
-      if (xIsValid && yIsValid) {
+      const filterValue = filterArg ? evaluateNode(filterArg, scope) : true
+      if (xIsValid && yIsValid && isValueTruthy(filterValue)) {
         result = fn(lsrResult, x, y)
       }
     })