Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #354, the
CloudContent.getClientContent()
function was changed from:to
under the mistaken assumption that the
CloudContent.wrapFileContent
setting was a reliable indicator of whether the content in question was wrapped in CFM metadata or not. It turns out that the content is always wrapped internally by the CFM--theCloudContent.wrapFileContent
setting merely determines whether it should be saved to file/disk in its wrapped or unwrapped form. The problem with the original form of the test is that some clients, e.g. CODAP v3, have an internalcontent
property which results ingetClientContent()
returning the interior content in error. The proper fix from this PR is:The rest of the changes in this PR are additional comments, tests, and minor refactoring to make all of this a bit clearer.