Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finnish translation #50

Merged
merged 3 commits into from
Jun 2, 2020
Merged

Finnish translation #50

merged 3 commits into from
Jun 2, 2020

Conversation

mhavu
Copy link
Contributor

@mhavu mhavu commented May 22, 2020

This PR adds a Finnish translation to the GDPR edition. BTW, there is a small discrepancy in what is included in the localised versions of OBC-GDPR-ULT and OBC-GDPR-DUA: the localised versions of OBC-GDPR-ULT seem to include the Instructions chapter (albeit without the chapter heading), whereas the localised versions of OBC-GDPR-DUA do not include the General considerations for a Data User Agreement chapter or the introductory text.

General considerations for a Data User Agreement was included in the Google Docs translation package, so I have translated it, but did not include it in the PR, since it was omitted from other language versions. I'll add it here, in case it was meant to be included:

Yleisiä huomioita tietojen käyttäjän käyttöoikeussopimuksesta
--------------------------------------------------------------

Biolääketieteelliset tiedot ovat EU:n tietosuoja-asetuksen (GDPR) mukaan henkilötietoja. Tämän käyttöoikeussopimuksen on tarkoitus olla niin rajoittava, että se soveltuu biolääketieteellisten tietojen julkiseen jakamiseen. Jos tietojen jakaminen liittyy meneillään olevaan yhteistyöhön, suosittelemme sallivampaa sopimusta.

- Sopimuksen on soveltuvin osin määrättävä, miten tutkittavien yksityisyyden suojasta pidetään huolta.
- Toissijaisten tietojen ja johdannaistietojen uudelleenjakamista käsittelevä kohta 4 on kiistanalainen. Sen sisällyttämisen tai pois jättämisen tulee perustua huolelliseen harkintaan.
- Kohtaan 4 liittyen voidaan määrätä, miten tietojen alkuperäinen lähde ilmoitetaan julkaisuissa. Voit esimerkiksi määrätä, haluatko tulla mainituksi, jos joku käyttää mallinetta, jonka jokin kolmas osapuoli (tutkija tai tutkimusryhmä) on luonut julkaisemiesi tietojen pohjalta.

@yarikoptic
Copy link
Member

Thank you!
I also mentioned that discrepancy but forgot to ask gdpr working group ppl. May be @CPernet could clarify.
I personally would've included instructions as well. Other translations could have caught up later

@mhavu
Copy link
Contributor Author

mhavu commented May 22, 2020

I am confused now. I thought I pushed this to my own fork. How come it appeared upstream as well?

Ah, I got it now. I didn't know PRs work like this, since I've never tried adding another one to the same repository before the previous one was merged.

@yarikoptic
Copy link
Member

Great! You could also (while in this branch locally)
git reset --hard e00c9587f8cb62799c41dde0416c4997d4540ef8 ; git push -f to completely get rid of the last two commits in this branch/pr

@mhavu
Copy link
Contributor Author

mhavu commented May 22, 2020

Done. Thanks for the tip!

@yarikoptic
Copy link
Member

I wish I knew some Finnish people to review/proofread this PR, but the only one I know (but he doesn't know me) is @torvalds and I bet he is occupied with other stuff. Anyone from @con/i18n team could recommend someone to invite to our @con/finnish team and review this PR's content? ;)

@yarikoptic
Copy link
Member

Re instructions: let's continue in #56 .

@yarikoptic
Copy link
Member

A tweet was sent out seeking reviewers, let's see if any kind soul follows up.

@mhavu
Copy link
Contributor Author

mhavu commented May 27, 2020

I used to be a professional translator, but I don't think any of the reviewers I know from that era are on GitHub. I retweeted in the hopes that one of my neuroscientist colleagues will volunteer.

@yarikoptic
Copy link
Member

I will merge as is if nobody chimes in by Monday

@yarikoptic yarikoptic merged commit 7d7c411 into con:master Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants