Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obscure wording in the GDPR edition #51

Closed
mhavu opened this issue May 22, 2020 · 13 comments
Closed

Obscure wording in the GDPR edition #51

mhavu opened this issue May 22, 2020 · 13 comments
Labels

Comments

@mhavu
Copy link
Contributor

mhavu commented May 22, 2020

The wording in More information about your rights when processing data implies that it is the participant who processes the data. This could be remedied, for example, by changing "your rights when processing your personal data" to "your rights regarding the processing of your personal data" or "your rights when your personal data is processed".

@yarikoptic
Copy link
Member

Indeed. Either suggested version is good with me. PR? Attn @con/gdpr

@yarikoptic
Copy link
Member

Note: When changing for meaning like this, which might need translations adjustment, the minor version component would need a boost, or to 1.1.0 version in the file

mhavu added a commit to mhavu/open-brain-consent that referenced this issue May 22, 2020
@CPernet
Copy link
Contributor

CPernet commented May 22, 2020

if we change English - we should then push an issue for i18 team as to have all other translations adjusted as well ; kind of the problem with that many but we could also have a warning that English is ahead ??

mhavu added a commit to mhavu/open-brain-consent that referenced this issue May 22, 2020
This reverts commit 7c62439.
mhavu added a commit to mhavu/open-brain-consent that referenced this issue May 22, 2020
@mhavu
Copy link
Contributor Author

mhavu commented May 22, 2020

Most localisations should not require more than a bump in the version number. In my opinion, this could be combined with notifying the i18n team of what is to be included in the localised versions of OBC-GDPR-ULT and OBC-GDPR-DUA: currently the localised versions of OBC-GDPR-ULT seem to include the Instructions chapter without the chapter heading, whereas the localised versions of OBC-GDPR-DUA do not include the General considerations for a Data User Agreement chapter or the introductory text. In case these are to be translated, the version number should not be touched without also including the missing translations.

(As a side note, the contents of data_user_agreement.nl.rst seem to be Turkish, not Dutch.)

@yarikoptic
Copy link
Member

(As a side note, the contents of data_user_agreement.nl.rst seem to be Turkish, not Dutch.)

crap -- might have been the bug I introduced when trying to merge multiple splitting efforts...

NB better to submit such issues separately so they do not get swallowed within other issues ;)

@yarikoptic
Copy link
Member

(As a side note, the contents of data_user_agreement.nl.rst seem to be Turkish, not Dutch.)
crap -- might have been the bug I introduced when trying to merge multiple splitting efforts...

nope - it was added as such in 31ca1d6 so @CPernet might know where to get the original translation

indeed - there is no diff between .nl and .tr ;)
$> diff data_user_agreement.nl.rst data_user_agreement.tr.rst
1c1
< .. _chap_dua_nl:
---
> .. _chap_dua_tr:
3,5c3,5
< Dutch
< -----
< (translation courtesy of Dr Patricia Clement and Dr Henk-Jan Mutsaerts)
---
> Turkish
> -------
> (translation courtesy of Dr. Esin Öztürk Işık)
8c8
< ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
---
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
10c10
< **Version:** OBC-GDPR-DUA.nl 1.0.0
---
> **Version:** OBC-GDPR-DUA.tr 1.0.0

@mhavu
Copy link
Contributor Author

mhavu commented May 22, 2020

NB better to submit such issues separately so they do not get swallowed within other issues ;)

Indeed. I just figured this would be blatantly obvious to the maintainers of the Dutch localisation when they check those other things.

@CPernet
Copy link
Contributor

CPernet commented May 25, 2020

pulling the old 'one file' and copy/paste over -- pulling the update from my fork and doing a PR -- re dutch fixing

@CPernet
Copy link
Contributor

CPernet commented May 25, 2020

re english fixing -- noting against it but in this case we should submit the change in i18 so others also make changes in translations (otherwise it is becoming too divergent)

@mhavu
Copy link
Contributor Author

mhavu commented May 25, 2020

@CPernet What about the scope of the translation? Should the instructions in the beginning of the files also be included?

@yarikoptic
Copy link
Member

yarikoptic commented May 25, 2020

I think we don't need to translate them. They seems to be not participant oriented really. So let's just decide on fixing wording: after fixed in English, we need to initiate changelog probably per each of translatable versions items, list it there and contact i18n teams to adjust corresponding translations. Might take awhile so I would release without waiting for that. With a changelog and version disparity users might see it and fix it up when used and possibly even submit corrections

@mhavu
Copy link
Contributor Author

mhavu commented May 25, 2020

I think we don't need to translate them. They seems to be not participant oriented really.

In that case I would also remove the Instructions chapter (first paragraph) from OBC-GDPR-ULT.

@yarikoptic
Copy link
Member

ok, let's continue on this specific issue in #56 . I would not make it a blocker for the release though. The initial issue on wording - we better at least decide before release on what we do with it

mhavu added a commit to mhavu/open-brain-consent that referenced this issue May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants