fix Issue5847 as required（make the icon always visible and just adjust the count accordingly） #5901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t adjust the count accordingly,comment the setVisibility method and make pending_upload_icon always visible
sivaraam
reviewed
Oct 28, 2024
Comment on lines
+313
to
+319
| // public void setUploadIconVisibility() { | ||
| // contributionController.getFailedAndPendingContributions(); | ||
| // contributionController.failedAndPendingContributionList.observe(getViewLifecycleOwner(), | ||
| // list -> { | ||
| // updateUploadIcon(list.size()); | ||
| // }); | ||
| // } |
There was a problem hiding this comment.
Could you add a comment here and possible in other changed places linking to relevant comment on why we're doing this ? This would be helpful context to know the rationale behind this change 🙂
Comment on lines
+314
to
+315
| // contributionController.getFailedAndPendingContributions(); | ||
| // contributionController.failedAndPendingContributionList.observe(getViewLifecycleOwner(), |
There was a problem hiding this comment.
I think we could also comment the failedAndPendingContributionList member and the corresponding getFailedAndPendingContributions as I suppose they are not used for any other purpose.
|
@bxy379987 Any chance to address Sivaraam's comments above? Thanks! :-) |
|
Ok sir, sorry, I was taking four exam this two weeks, I forgot to continue , I will improve it again before the end of this week |
…le the original code has been commented out and retained with a note for potential re-use in the future.
nicolas-raoul
requested changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
comment out the setVisibility method and all calls to setVisibility method， and make pending_upload_icon always visible
Description (required)
Fixes #5847
What changes did you make and why?
Comment out the original setVisibility method and related methods, then set pending_upload_icon to visible, to ensure that the pending_upload_icon is always visible on the contribution interface, making it convenient for users
Tests performed (required)
the upload_icon is always visible
Tested {build variant, e.g. ProdDebug} on {Pixel 8} with API level {API 34}.
Screenshots (for UI changes only)
Need help? See https://support.google.com/android/answer/9075928
Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.