Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 5284 prevent retries for genuinely failed uploads #5613

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Issue 5284 prevent retries for genuinely failed uploads #5613

wants to merge 12 commits into from

Commits on Feb 28, 2024

  1. docs: add notes in UploadWorker for where we need to determine the error

    @Glassar
    Glassar committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    a845585 View commit details
    Browse the repository at this point in the history

  2. docs: more thorough evaluation of failure points in UploadWorker

    @Glassar
    Glassar committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    c8ff6ea View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. feat: add errorMessage argument to the contribution class

    Melissa Mazura committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    a23dd70 View commit details
    Browse the repository at this point in the history

  2. feat: change the errormessage to show what failure occurs

    Melissa Mazura committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    ba77b64 View commit details
    Browse the repository at this point in the history

  3. feat: add exception argument for upload failures

    Melissa Mazura committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    326426c View commit details
    Browse the repository at this point in the history

  4. feat: add exception argument to the contribution class

    Melissa Mazura committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    cebb9d2 View commit details
    Browse the repository at this point in the history

  5. fix: fix the error message handling in the code

    Melissa Mazura committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    bed8c29 View commit details
    Browse the repository at this point in the history

  6. feat: add feature to check whether the error is a genuine error

    Melissa Mazura committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    59f1dbf View commit details
    Browse the repository at this point in the history

  7. fix: fix the exception messages and their usage

    Melissa Mazura committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    0f99a9f View commit details
    Browse the repository at this point in the history

  8. refactor: change type of exceptionMessage to string

    Melissa Mazura committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    d75c3a6 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. style: clean up the code

    Melissa Mazura committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    140ec0c View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Merge branch 'commons-app:main' into issue-5284_Prevent_retries_for_g… 

    …enuinely_failed_uploads
    @Glassar
    Glassar authored Mar 7, 2024
    Configuration menu
    Copy the full SHA
    7153fef View commit details
    Browse the repository at this point in the history