Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document a difference between git and github in extra-deps #6037

Merged
merged 1 commit into from
Jan 21, 2023

Conversation

jorpic
Copy link
Contributor

@jorpic jorpic commented Jan 21, 2023

I spent some time trying to understand why github: user/repo in extra-deps does not work if repo contains git submodules.
Probably it worth to explicitly mention the difference between git and github in documentation.

ref #5603

@mpilgrem mpilgrem changed the base branch from master to stable January 21, 2023 19:01
@mpilgrem
Copy link
Member

@jorpic, I changed the base branch, because pull requests for improvements to documentation that are applicable to the current released version of Stack should target this repository's stable branch.

@mpilgrem mpilgrem merged commit 64bdf56 into commercialhaskell:stable Jan 21, 2023
@mpilgrem
Copy link
Member

@jorpic, post-merging, I made some further changes to this part of the documentation. The help on GitHub archive files was in the wrong location, adding to the confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants