Support basic auth #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not on board with this approach, it's too easy to accidentally ignore the subtle differences between the local and upstream versions of the function. How about modifying |
|
✨ _**This is an old work account. Please reference @brandonchinn178 for all future communication**_ ✨
<!-- updated by mention_personal_account_in_comments.py -->
…---
Sure, I can make a completely separate function instead of shadowing the
function in Pantry.HTTP.
The problem we're trying to solve is using a private hackage instance that
requires authentication. So trying to do
```yaml
package-indices:
- download-prefix: https://user:[email protected]
```
Will fail to pass the username and password through
|
|
LGTM. Can you add a version bump and changelog entry? |
|
✨ This is an old work account. Please reference @brandonchinn178 for all future communication ✨ Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ This is an old work account. Please reference @brandonchinn178 for all future communication ✨
Fixes commercialhaskell/stack#5509
Tested that it works with our private hackage instance