Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #129 loadRawPackage works with submodules in PowerShell #130

Closed
wants to merge 1 commit into from
Closed

Fix #129 loadRawPackage works with submodules in PowerShell #130

wants to merge 1 commit into from

Conversation

mpilgrem
Copy link
Member

@mpilgrem mpilgrem commented Feb 23, 2024 •
edited
Loading

Currently testing with a modified version of Stack.

Outside of the git submodule foreach environment, the tar on Windows outside of Stack's environment is likely bsdtar. Stack.SetupCmd.setupCmd uses withBuildConfig not withDefaultEnvConfig.

@mpilgrem
Copy link
Member Author

mpilgrem commented Feb 23, 2024 •
edited
Loading

I assume that the failure of TreeSpec archive and Git repo match on Windows is something to do with LF v CRLF.

EDIT: I have subsequently fixed the line ending processing problem, but now have a problem with the preservation of file attributes. git archive knows, for example, that test-inject.sh is marked as 'executable'. git clone followed by tar does not preserve that attribute on Windows.

@mpilgrem mpilgrem marked this pull request as draft February 24, 2024 13:32
@mpilgrem
Copy link
Member Author

Closing, as this was based on a false premise as to what was the underlying issue.

@mpilgrem mpilgrem closed this Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mpilgrem