Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put telemetry on dehydration #552

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Put telemetry on dehydration #552

wants to merge 4 commits into from

Conversation

cdegroot
Copy link
Contributor

This puts start/stop events around processing the event stream, including the count of events loaded. I think that this is a useful metric to monitor for/to quickly sniff out aggregate (types) that require snapshotting.

drteeth
drteeth requested changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@drteeth drteeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cdegroot if you rebase the first commit out we can get this merged. The first one is from #551 which we closed.

@jwilger
Copy link
Contributor

jwilger commented Jan 8, 2025

@cdegroot if you rebase the first commit out we can get this merged. The first one is from #551 which we closed.

A squash-merge should obviate the need for a rebase first, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drteeth drteeth drteeth requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cdegroot @jwilger @drteeth