Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Python 3.12 #32545

Closed
wants to merge 15 commits into from
Closed

Update to Python 3.12 #32545

wants to merge 15 commits into from

Conversation

BBBmau
Copy link
Contributor

@BBBmau BBBmau commented May 26, 2024

Fixes #32516

Copy link
Contributor

github-actions bot commented May 26, 2024

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

pyproject.toml Outdated Show resolved Hide resolved
Co-authored-by: Adeeb Shihadeh <[email protected]>
@BBBmau
Copy link
Contributor Author

BBBmau commented May 26, 2024

For context: I went ahead and created a python package from my metadrive PR just so we don't have to wait. We can change it to be the original metadrive package once a new release is made with it.

https://pypi.org/project/metadrive-simulator-py3-12/0.2.0/

@BBBmau
Copy link
Contributor Author

BBBmau commented May 27, 2024

This seems like a common issue with moving to 3.12: ModuleNotFound Error: No module named six.moves``

I see a lot of mentions and how using 3.11 fixed it 😕

Datalux/Osintgram#947 (comment)

@BBBmau
Copy link
Contributor Author

BBBmau commented May 27, 2024

removing --system-site-packages solved the previous issue that I was having where six modules were not being found.

@BBBmau
Copy link
Contributor Author

BBBmau commented May 27, 2024

closing since this relies on pyenv being removed. Making a new PR that adds support with pyenv present.

@BBBmau BBBmau closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[$250 bounty] Update to Python 3.12
2 participants