[OPIK-539]: add a config tab and proxy; #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferc
approved these changes
Dec 18, 2024
| workspaceName, | ||
| }, | ||
| { | ||
| placeholderData: keepPreviousData, |
| React.ComponentPropsWithoutRef<typeof SelectPrimitive.Item> | ||
| >(({ className, children, ...props }, ref) => ( | ||
| SelectItemProps | ||
| >(({ className, children, withoutCheck = false, ...props }, ref) => ( |
There was a problem hiding this comment.
@andriidudar take a look at it in case you have some strong opinion about it
There was a problem hiding this comment.
Good implementation, no comments from my side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
https://www.figma.com/design/4DchV5t7FXiwngzBUiqcZ3/Opik-UI?node-id=1584-639010&t=KpuRfR1MKIGoSTjV-0
Moved the Feedback defintions to configuration tab and restyled it a bit:
Fixed the e2e tests for them
Added AI Providers tab:
Removed the usage of tokens from local storage
Playground improvements
Now, the playground uses the proxy to get the OpenAI calls. So, we don't need to put a token manually
Handling errors:
If a provider is set, the default model is picked:
Issues
Resolves
https://comet-ml.atlassian.net/browse/OPIK-539
Testing
Changed the tests for feedback definitions
Documentation