[OPIK-446] remove materialized column #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrescrz
previously approved these changes
Dec 18, 2024
idoberko2
commented
Dec 18, 2024
| @@ -42,7 +42,12 @@ public class FilterQueryBuilder { | |||
| private static final String USAGE_PROMPT_TOKENS_ANALYTICS_DB = "usage['prompt_tokens']"; | |||
| private static final String USAGE_TOTAL_TOKENS_ANALYTICS_DB = "usage['total_tokens']"; | |||
| private static final String VALUE_ANALYTICS_DB = "value"; | |||
| private static final String DURATION_ANALYTICS_DB = "duration_millis"; | |||
| private static final String DURATION_ANALYTICS_DB = """ | |||
There was a problem hiding this comment.
@andrescrz, this is done as a quick fix. I will make a proper fix in a later PR
andrescrz
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
To avoid migration on large tables, we decided to make this calculation inline at the moment.
Issues
OPIK-446