Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OPIK-437]: add fe cost chart #778

Merged
merged 15 commits into from
Dec 2, 2024
Merged

[OPIK-437]: add fe cost chart #778

merged 15 commits into from
Dec 2, 2024

Conversation

aadereiko
Copy link
Contributor

@aadereiko aadereiko commented Dec 2, 2024 •
edited
Loading

Details

  • add a cost chart
image * worked on the tick width and formatting behavior

Issues

Resolves #

  • also fixes the issues for the cases where the cost didn't fit:
image

Testing

Documentation

@aadereiko aadereiko requested a review from a team as a code owner December 2, 2024 09:40
andriidudar
andriidudar requested changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@andriidudar andriidudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. I have left one minor comment in regards to import from lodash.

Can you please clarify with the Product team the way how Y axis ticks are behave now for experiments.

Before:
image

After:
image

apps/opik-frontend/src/hooks/charts/useChartTickDefaultConfig.ts Outdated
@@ -0,0 +1,121 @@
import { useCallback, useMemo } from "react";
import { isInteger, max, min } from "lodash";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets not mix type of import from lodash, lets import utils one by one (theoretically it affects bundle size)

@aadereiko aadereiko requested a review from andriidudar December 2, 2024 14:34
andriidudar
andriidudar approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@andriidudar andriidudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andriidudar andriidudar merged commit fc1b7a3 into main Dec 2, 2024
1 check passed
@andriidudar andriidudar deleted the sashaa/OPIK-437/add-fe-cost-chart branch December 2, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andriidudar andriidudar andriidudar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aadereiko @andriidudar