[OPIK-415] Compute traces cost based on token usage #703
+70
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BorisTkachenko
force-pushed
the
boryst/OPIK-415-tracing-compute-traces-cost-based-on-token-usage
branch
from
00b21ea to
dd0b37f
Compare
thiagohora
reviewed
Nov 25, 2024
| @@ -581,7 +581,7 @@ AND id in ( | |||
| """; | |||
|
|
|||
| private static final String ESTIMATED_COST_VERSION = "1.0"; | |||
| private static final BigDecimal ZERO_COST = new BigDecimal("0.00000000"); | |||
| public static final BigDecimal ZERO_COST = new BigDecimal("0.00000000"); | |||
There was a problem hiding this comment.
Suggested change
| public static final BigDecimal ZERO_COST = new BigDecimal("0.00000000"); | |
| public static final BigDecimal ZERO_COST = new BigDecimal.ZERO; |
| @@ -747,6 +753,9 @@ private Publisher<Trace> mapToDto(Result result) { | |||
| .filter(it -> !it.isEmpty()) | |||
| .orElse(null)) | |||
| .usage(row.get("usage", Map.class)) | |||
| .totalEstimatedCost(row.get("total_estimated_cost", BigDecimal.class).equals(ZERO_COST) | |||
There was a problem hiding this comment.
We probably should use compareTo
There was a problem hiding this comment.
Yes, now it's a must, since we changed to BigDecimal.ZERO.
equals works only for the same precision comparison and is not robust. Good catch.
BorisTkachenko
force-pushed
the
boryst/OPIK-415-tracing-compute-traces-cost-based-on-token-usage
branch
3 times, most recently
from
d8a8ec8 to
2be4465
Compare
thiagohora
reviewed
Nov 25, 2024
| @@ -581,7 +581,7 @@ AND id in ( | |||
| """; | |||
|
|
|||
| private static final String ESTIMATED_COST_VERSION = "1.0"; | |||
| private static final BigDecimal ZERO_COST = new BigDecimal("0.00000000"); | |||
| public static final BigDecimal ZERO_COST = BigDecimal.ZERO; | |||
There was a problem hiding this comment.
No need for this constant just use the one from BigDecimal
| .toBuilder() | ||
| .id(null) | ||
| .projectName(projectName) | ||
| .usage(Map.of("completion_tokens", 200 * 5L, "prompt_tokens", 300 * 5L, "total_tokens", 4 * 5L)) |
There was a problem hiding this comment.
Can we generate random values to make the test more robust?
There was a problem hiding this comment.
No we can't. It should be related to spans to assert and also usage keys should be specific for cost calculation and can't be random.
There was a problem hiding this comment.
I mean something like this:
Spans
.usage(Map.of("completion_tokens", factory. manufacturePojo(Integer.class), "prompt_tokens", factory. manufacturePojo(Integer.class), "total_tokens", factory. manufacturePojo(Integer.class)))
Then, in the traces, we just group by usage name and calculate the avg expected
There was a problem hiding this comment.
I updated per your request. But could you please explain how hardcoded usage values might introduce flakiness?
BorisTkachenko
force-pushed
the
boryst/OPIK-415-tracing-compute-traces-cost-based-on-token-usage
branch
from
2be4465 to
9215e66
Compare
BorisTkachenko
force-pushed
the
boryst/OPIK-415-tracing-compute-traces-cost-based-on-token-usage
branch
from
9215e66 to
6a2f37b
Compare
BorisTkachenko
force-pushed
the
boryst/OPIK-415-tracing-compute-traces-cost-based-on-token-usage
branch
from
6a2f37b to
2ea154e
Compare
thiagohora
approved these changes
Nov 26, 2024
BorisTkachenko
deleted the
boryst/OPIK-415-tracing-compute-traces-cost-based-on-token-usage
branch
thiagohora
reviewed
Nov 26, 2024
Comment on lines
+3264
to
+3267
| assertThat(traceExpectedCost.compareTo(BigDecimal.ZERO) == 0 ? | ||
| createdTrace.totalEstimatedCost() == null : | ||
| traceExpectedCost.compareTo(createdTrace.totalEstimatedCost()) == 0) | ||
| .isEqualTo(true); |
There was a problem hiding this comment.
Suggested change
| assertThat(traceExpectedCost.compareTo(BigDecimal.ZERO) == 0 ? | |
| createdTrace.totalEstimatedCost() == null : | |
| traceExpectedCost.compareTo(createdTrace.totalEstimatedCost()) == 0) | |
| .isEqualTo(true); | |
| var actual = createdTrace.totalEstimatedCost(); | |
| traceExpectedCost = traceExpectedCost.compareTo(BigDecimal.ZERO) == 0 ? null : traceExpectedCost; | |
| assertThat(actual) | |
| .usingRecursiveComparison(RecursiveComparisonConfiguration.builder() | |
| .withComparatorForType(BigDecimal::compareTo, BigDecimal.class) | |
| .build()) | |
| .isEqualTo(traceExpectedCost); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Computes trace cost based on token usage
Resolves #OPIK-415
Testing
Added integration tests
Documentation
https://www.notion.so/cometml/Opik-Span-Cost-tracking-13c7124010a380a7ad36ced128a26dc7