Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: Updated Python SDK fern autogenerated code #700

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

andrescrz
Copy link
Collaborator

@andrescrz andrescrz commented Nov 22, 2024

Details

I run the following script:

./scripts/generate_openapi.sh

So sdks/python/code_generation/fern/openapi/openapi.yaml was updated with the latest backend API, so all Python SDK Fern autogenerated code was updated under sdks/python/src/opik/rest_api/ folder.

Triggering the backend build also caused Java code to be formatted with Spotless.

Issues

N/A

Testing

  • Passed CI build.

Documentation

N/A

@andrescrz andrescrz force-pushed the andrescrz/update-python-fern-autogenerated-code branch from c299cf1 to 44d1626 Compare November 22, 2024 14:08
@andrescrz andrescrz self-assigned this Nov 22, 2024
@andrescrz andrescrz added the enhancement New feature or request label Nov 22, 2024
@andrescrz andrescrz marked this pull request as ready for review November 22, 2024 14:14
@andrescrz andrescrz requested a review from a team as a code owner November 22, 2024 14:14
thiagohora
thiagohora previously approved these changes Nov 22, 2024
Copy link
Contributor

@thiagohora thiagohora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably need to add format validation in the pipeline

@andrescrz
Copy link
Collaborator Author

We probably need to add format validation in the pipeline

There's a Github action for this already:

Also, the ./scripts/generate_openapi.sh script automatically runs pre-commit and all Python SDK files.

@thiagohora
Copy link
Contributor

thiagohora commented Nov 22, 2024

We probably need to add format validation in the pipeline

There's a Github action for this already:

Also, the ./scripts/generate_openapi.sh script automatically runs pre-commit and all Python SDK files.

Yeah, I mean for Java, since many of your changes in Java were formatting. Anyway, it's approved.

@alexkuzmik
Copy link
Collaborator

Please update the readme in code_generation so that everybody know we now have this script

@andrescrz
Copy link
Collaborator Author

We probably need to add format validation in the pipeline

There's a Github action for this already:

Also, the ./scripts/generate_openapi.sh script automatically runs pre-commit and all Python SDK files.

Yeah, I mean for Java, since many of your changes in Java were formatting. Anyway, it's approved.

That makes sense. We can do it in next PRs.

@andrescrz
Copy link
Collaborator Author

Please update the readme in code_generation so that everybody know we now have this script

Done in revision 2.

@andrescrz andrescrz force-pushed the andrescrz/update-python-fern-autogenerated-code branch from 608a694 to 22cf42a Compare November 22, 2024 15:04
@andrescrz andrescrz merged commit 66f0985 into main Nov 22, 2024
25 checks passed
@andrescrz andrescrz deleted the andrescrz/update-python-fern-autogenerated-code branch November 22, 2024 15:10
aadereiko pushed a commit that referenced this pull request Nov 25, 2024
* NO-JIRA: Updated Python SDK fern autogenerated code

* Rev2: update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants