datasets tests, GHA merging, minor fix-ups #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferc
approved these changes
Nov 21, 2024
Comment on lines
+50
to
+58
| try: | ||
| datasets_page = DatasetsPage(page) | ||
| datasets_page.go_to_page() | ||
| datasets_page.check_dataset_exists_on_page_by_name(dataset_name=dataset_name) | ||
| except Exception as e: | ||
| print(f'error: dataset not created: {e}') | ||
| raise | ||
| finally: | ||
| delete_dataset_by_name_if_exists(dataset_name=dataset_name) |
There was a problem hiding this comment.
Is this print something that you need for something in particular? I mean, why not letting it fail and having some way to "after" the test run hook to destroy the dataset?
Not sure I get the idea on why to wrap every creation on try/catch here, I believe it should be a better way to handle it but for now we can keep it as is
aadereiko
pushed a commit
that referenced
this pull request
Nov 25, 2024
* datasets tests, GHA merging, minor fix-ups * descriptions * fix dataset creation when no datasets created * traces locator fix * fixed sanity after UI changes too --------- Co-authored-by: Andrei Căutișanu <[email protected]> Co-authored-by: Andrei Căutișanu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Tests for datasets CRUD operations.
Coverage:
Also in this PR:
Merging of the 2 Github Actions workflow files, now both the sanity suite and specific feature suites (or all of them) can be ran from the same "Application E2E tests" workflow