Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEV-2440] opik chart improvements #650

Merged
merged 9 commits into from
Nov 17, 2024
Merged

[DEV-2440] opik chart improvements #650

merged 9 commits into from
Nov 17, 2024

Conversation

liyaka
Copy link
Contributor

@liyaka liyaka commented Nov 17, 2024 •
edited
Loading

Details

  • added bitnami-common as a dependency to opik chart to support simpler value configurations
  • add variable for clickhouse backup bucket
  • add toleration and nodeSelector for clickhouse backup job
  • set default successfulJobsHistoryLimit=1 for clickhouse backup cronjob

Issues

Resolves #

Testing

Tested on Dev

Documentation

@liyaka liyaka requested review from a team as code owners November 17, 2024 11:59
@liyaka liyaka changed the title [DEV-2440]add bitnami common chart dependency [DEV-2440] opik chart improvements Nov 17, 2024
@liyaka liyaka force-pushed the liya/DEV-2440-add-bitnami-comon-chart-dep branch from 02d0b01 to ef8cd6a Compare November 17, 2024 16:21
idoberko2
idoberko2 approved these changes Nov 17, 2024
View reviewed changes
Copy link
Contributor

@idoberko2 idoberko2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liyaka liyaka merged commit 31ad8a9 into main Nov 17, 2024
2 checks passed
@liyaka liyaka deleted the liya/DEV-2440-add-bitnami-comon-chart-dep branch November 17, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idoberko2 idoberko2 idoberko2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liyaka @idoberko2 @CometActions