[OPIK-313] Delete prompt #556
Merged
+80
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…github.com/comet-ml/opik into thiagohora/OPIK-309_exposing_api_contracts
…hora/OPIK-309_exposing_api_contracts
…hora/OPIK-309_exposing_api_contracts
…hora/OPIK-310_expose_get_prompts_api
…hora/OPIK-310_expose_get_prompts_api
…hora/OPIK-314_create_version_endpoint
thiagohora
force-pushed
the
thiagohora/OPIK-311_update_prompt
branch
from
3b58058 to
09c3cae
Compare
thiagohora
force-pushed
the
thiagohora/OPIK-311_update_prompt
branch
from
09c3cae to
faebd86
Compare
…-313_delete_prompts
idoberko2
previously approved these changes
Nov 5, 2024
| @@ -50,4 +50,7 @@ List<Prompt> find(@Define("name") @Bind("name") String name, @Bind("workspace_id | |||
| + | |||
| " WHERE id = :bean.id AND workspace_id = :workspace_id") | |||
| int update(@Bind("workspace_id") String workspaceId, @BindMethods("bean") Prompt updatedPrompt); | |||
|
|
|||
| @SqlUpdate("DELETE FROM prompts WHERE id = :id AND workspace_id = :workspace_id") | |||
There was a problem hiding this comment.
Don't we use soft deletes in opik?
There was a problem hiding this comment.
No, probably at some point, we need to rethink this, but right now we do hard deletes
idoberko2
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Issues
OPIK-313