Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OPIK-218] Allow null custom fields #399

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

thiagohora
Copy link
Contributor

@thiagohora thiagohora commented Oct 16, 2024

Details

Allow null custom fields

Issues

OPIK-218

Test

1 * Sending client request on thread main
1 > PUT http://localhost:64258/v1/private/datasets/items
1 > Accept: application/json
1 > Authorization: [redacted]
1 > Comet-Workspace: fcad5ab8-81dc-4afb-bea0-5e31a779de45
1 > Content-Type: application/json
{"dataset_name":"Dxy3ajznes","items":[{"id":"019295bf-eb3a-7039-8f70-081dcb7b1b2e","input":{"a5cfoWjH9m":"v6adRGluPX","haJhM7bxmU":"M2ZVpQcurR","DKgvnHVoMc":"VnEPhyQVME","TCD8si3J1w":"oGYB5aRNO0","V9k48d4K9I":"XL2yuu9nd0"},"expected_output":{"p8GpolcCVj":"zwFA5ruYEv","fBXysf5a2L":"rF2goFpFuF","ed8xBpjs7l":"xhbKDNcjqS","z6kkjaAEVt":"KA51rxsgSF","60WfjGubtj":"Iye6DHKe68"},"metadata":{"EdkEnQQNjr":"UHCElyCBQx","5xuTVl8udL":"jII7zJGDtM","7MH4KeamGd":"yeX242v2oO","HhR6jysGuf":"Y5nwVNpHfm","y0o0hHNq4L":"CSmkAGTXWw"},"trace_id":"019295bf-eb33-7a27-9af7-c88e0ef4998a","source":"trace","data":{"test":null},"created_at":"2024-10-16T14:33:55.770756Z","last_updated_at":"2024-10-16T14:33:55.770757Z"}]}

}----------------------------------------------------------

Add test to ensure the support works

{"id":"019295bf-eb3a-7039-8f70-081dcb7b1b2e","input":{"a5cfoWjH9m":"v6adRGluPX","haJhM7bxmU":"M2ZVpQcurR","DKgvnHVoMc":"VnEPhyQVME","TCD8si3J1w":"oGYB5aRNO0","V9k48d4K9I":"XL2yuu9nd0"},"expected_output":{"p8GpolcCVj":"zwFA5ruYEv","fBXysf5a2L":"rF2goFpFuF","ed8xBpjs7l":"xhbKDNcjqS","z6kkjaAEVt":"KA51rxsgSF","60WfjGubtj":"Iye6DHKe68"},"metadata":{"EdkEnQQNjr":"UHCElyCBQx","5xuTVl8udL":"jII7zJGDtM","7MH4KeamGd":"yeX242v2oO","HhR6jysGuf":"Y5nwVNpHfm","y0o0hHNq4L":"CSmkAGTXWw"},"trace_id":"019295bf-eb33-7a27-9af7-c88e0ef4998a","source":"trace","data":{"input":{"a5cfoWjH9m":"v6adRGluPX","haJhM7bxmU":"M2ZVpQcurR","DKgvnHVoMc":"VnEPhyQVME","TCD8si3J1w":"oGYB5aRNO0","V9k48d4K9I":"XL2yuu9nd0"},"metadata":{"EdkEnQQNjr":"UHCElyCBQx","5xuTVl8udL":"jII7zJGDtM","7MH4KeamGd":"yeX242v2oO","HhR6jysGuf":"Y5nwVNpHfm","y0o0hHNq4L":"CSmkAGTXWw"},"test":null,"expected_output":{"p8GpolcCVj":"zwFA5ruYEv","fBXysf5a2L":"rF2goFpFuF","ed8xBpjs7l":"xhbKDNcjqS","z6kkjaAEVt":"KA51rxsgSF","60WfjGubtj":"Iye6DHKe68"}},"created_at":"2024-10-16T14:33:56.649824801Z","last_updated_at":"2024-10-16T14:33:56.649122093Z","created_by":"3734cabb-034d-422c-a3f4-0cd771be45bf","last_updated_by":"3734cabb-034d-422c-a3f4-0cd771be45bf"}

Documentation

@thiagohora thiagohora requested a review from a team as a code owner October 16, 2024 14:23
andrescrz
andrescrz previously approved these changes Oct 16, 2024
@thiagohora thiagohora merged commit 9d8ed61 into main Oct 16, 2024
7 checks passed
@thiagohora thiagohora deleted the thiagohora/OPIK-218_allow_null_custom_fields branch October 16, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants