Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OPIK-218] Data migration #397

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Conversation

thiagohora
Copy link
Contributor

Details

Migration following previous PR: #369

Issues

OPIK-218

Testing

  • Manually tested

@thiagohora thiagohora marked this pull request as ready for review October 16, 2024 14:50
@thiagohora thiagohora requested a review from a team as a code owner October 16, 2024 14:50
@thiagohora thiagohora self-assigned this Oct 16, 2024
Copy link
Collaborator

@andrescrz andrescrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, this has some risk when run as a migration as it'd be desirable to be run by an operator.

On the other hand, this it's useful for open source users.

The risks where discussed and accepted.

As you're planning to implement filling the data with the input, expected_output and metadata field, my recommendation would be to merge that first in order to see how critical is to perform this migration.

@thiagohora
Copy link
Contributor Author

Hi @andrescrz,

I noticed something interesting: in dev, I tried to run the query to validate it, and it generated the new rows. However, I can still see the old ones. It only does it after running OPTIMIZE TABLE dataset_items FINAL;

Do you think this is expected?

@thiagohora
Copy link
Contributor Author

Hi @andrescrz,

I noticed something interesting: in dev, I tried to run the query to validate it, and it generated the new rows. However, I can still see the old ones. It only does it after running OPTIMIZE TABLE dataset_items FINAL;

Do you think this is expected?

Confirmed, the behavior is expected as it's up to the engine to decide the best time to run the merge.

@thiagohora thiagohora merged commit f3c4494 into main Oct 18, 2024
7 checks passed
@thiagohora thiagohora deleted the thiagohora/OPIK-218_data_migration branch October 18, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants