Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OPIK-147] Add filters to dataset item experiment compare endpoint #359

Merged
merged 4 commits into from
Oct 9, 2024
Merged

[OPIK-147] Add filters to dataset item experiment compare endpoint #359

merged 4 commits into from
Oct 9, 2024

Conversation

thiagohora
Copy link
Contributor

@thiagohora thiagohora commented Oct 9, 2024 •
edited
Loading

Details

Add filters to experiment compare endpoint

GET /v1/private/datasets/{datasetId}/items/experiments/items

Issues

OPIK-147

Testing

  • Filter by INPUT, OUTPUT, EXPECTED_OUPUT, METADATA, FEEDBACK_SCORES (Happy path)
  • Invalid filter filter operations based on the type.

@thiagohora thiagohora changed the title [OPIK-147] Add filters to dataset item experiment compare endpoints [OPIK-147] Add filters to dataset item experiment compare endpoint Oct 9, 2024
@thiagohora thiagohora marked this pull request as ready for review October 9, 2024 13:15
@thiagohora thiagohora requested a review from a team as a code owner October 9, 2024 13:15
@thiagohora thiagohora self-assigned this Oct 9, 2024
@thiagohora thiagohora force-pushed the thiagohora/OPIK-147_add_filter_to_dataset_item_experiment_compare_endpoint branch from 2f542cc to cc90d4d Compare October 9, 2024 13:24
andrescrz
andrescrz approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@andrescrz andrescrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great to see that the query builder engine is easily and naturally extendable to other use cases. Well done!

@thiagohora thiagohora merged commit 373194c into main Oct 9, 2024
7 checks passed
@thiagohora thiagohora deleted the thiagohora/OPIK-147_add_filter_to_dataset_item_experiment_compare_endpoint branch October 9, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrescrz andrescrz andrescrz approved these changes

Assignees

@thiagohora thiagohora

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thiagohora @andrescrz