Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPIK-52 Add trace usage search #352

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

andrescrz
Copy link
Collaborator

@andrescrz andrescrz commented Oct 4, 2024

Details

Added support to search by trace usage: completion_tokens, prompt_tokens and total_tokens.
Behaviour is exactly the same as for span usage.
Since trace usage field is a calculated field instead of a normal field, I had to extend the query builder engine to support this use case.

Issues

OPIK-52

Testing

  • Added integration tests covering all the cases:
    • Covering the three usage tokens: completion_tokens, prompt_tokens and total_tokens.
    • All operations that apply: equals, greater than, greater equals than, lower than and lower equals than.

Documentation

  • N/A

@andrescrz andrescrz self-assigned this Oct 4, 2024
@andrescrz andrescrz added the enhancement New feature or request label Oct 4, 2024
@andrescrz andrescrz marked this pull request as ready for review October 4, 2024 16:46
@andrescrz andrescrz requested a review from a team as a code owner October 4, 2024 16:46
Copy link
Contributor

@thiagohora thiagohora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrescrz andrescrz merged commit 92f7857 into main Oct 7, 2024
7 checks passed
@andrescrz andrescrz deleted the andrescrz/OPIK-58-Add-trace-usage-search branch October 7, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants